1561252 - In today pane, on daily build , the text is outside the screen instead of being adapted

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Alex ARNAUD]

Attachment: TB today pane text outside the screen.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

1. Display the today pane
2. Create a event with a big title like this "I do a test for Thunderbird daily, the text goes out of the screen wheread adapated to the today pane before"

Actual results:

A part of the event title is outside of the screen.
I've attach a screenshot of the result.

Expected results:

It should be adapted to the screen space.
Note: As I remember it works in last stable release (60)

Comment 1

[Benjamin Flanagin]

Checking now,

The issue isn't reproducible on my computer in 68.0 beta1 or beta2. Are you using a custom font or theme? It could be something other than TB causing the pain to not display the title properly.

Comment 2

[Richard Marti (:Paenglab)]

I think, it's because in French the label "Prochainement (4 se..." is wider than the visible area. When the splitte would be moved to the left until on the bottom the scrollbar vanishes, then all would be good.

Comment 3

[Alex ARNAUD]

(In reply to Benjamin Flanagin from comment #1)

Checking now,

The issue isn't reproducible on my computer in 68.0 beta1 or beta2. Are you
using a custom font or theme? It could be something other than TB causing
the pain to not display the title properly.

Indeed, I've changed the font on my system but on TB 60 with the same steps it works. I've attach a screenshot with TB 60.

Comment 4

[Alex ARNAUD]

Attachment: TB 60 today pane text inside the screen.png

Comment 5

[Richard Marti (:Paenglab)]

This could be a regression from the de-XBL work. But I can't say from which.

Comment 6

[Magnus Melin [:mkmelin]]

I'd guess from bug 1534382?
Some css adjustments needed.

Comment 7

[Paul Morris [:pmorris]]

Attachment: wrapping-in-today-pane.png

I tried to reproduce this, but it is working for me on a current trunk build. This is on Ubuntu/GNU/Linux.

Comment 8

[Richard Marti (:Paenglab)]

Try it with making the "Upcoming" label longer than the minimum today pane width. Then you see that it gets a scrollbar on the bottom of this list.

Comment 9

[Alex ARNAUD]

FYI, I reproduce the same issue on Thunderbird 68.0b2.

Best regards,
Alex.

Comment 10

[Paul Morris [:pmorris]]

Thanks Richard. Yep, I can reproduce it that way now. Working on a fix now.

Comment 11

[Paul Morris [:pmorris]]

Attachment: today-pane-text-wrap-0.patch

This patch appears to fix the problem with a couple of CSS changes (at least here on linux).

Try server run for good measure, although I wouldn't expect this to affect any tests:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=9d376bea239140e8a32264ddb2a274d9e77d51f9

Comment 12

[Paul Morris [:pmorris]]

Attachment: today-pane-wrapping-correctly.png

Screenshot with it working.

Comment 13

[Richard Marti (:Paenglab)]

Comment on attachment 9075403 [details] [diff] [review]
today-pane-text-wrap-0.patch

Review of attachment 9075403 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, this works. r=me with the comment considered.

::: calendar/base/themes/common/today-pane.css
@@ +43,5 @@
>    color: inherit;
>  }
>  
> +.today-pane-panel-vbox {
> +  width: inherit;

Is this needed? Is the flex="1" not enough?

Comment 14

[Paul Morris [:pmorris]]

Attachment: today-pane-text-wrap-1.patch

Thanks for the review.

(In reply to Richard Marti (:Paenglab) from comment #13)

.today-pane-panel-vbox {
width: inherit;

Is this needed? Is the flex="1" not enough?

Huh, I just double checked and apparently it is not needed, so I've taken this part out. (Somehow in the process of working on it, it appeared to be needed before...)

Comment 15

[Paul Morris [:pmorris]]

jorgk: This should land on beta and trunk. This patch applies cleanly on the beta repo, so I haven't made a separate beta patch.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/81b346228baa
Fix text wrapping in today pane. r=Paenglab

Comment 17

[Jorg K (CEST = GMT+2)]

TB 68 beta 4 / Cal 7.0:
https://hg.mozilla.org/releases/comm-beta/rev/f5041f68a6e9129908e24160dd0d42e0e3b4a413