1561332 - ec.c:28 warning: comparison of integers of different signs: 'int' and 'unsigned long'

Status: RESOLVED FIXED

(NSS :: Build, defect, P2)

Description

[xhimanshuz]

Attachment: ec.c

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/75.0.3770.100 Safari/537.36

Steps to reproduce:

Build warning noticed while compiling Mozilla-central.
In for loop sizeof(kMethod) produced unsigned long that compare with signed int 'i' that is an iterator.
The compiler will cast 'i' as unsigned long before doing the comparison.

Actual results:

The compiler will cast 'i' as unsigned long before doing the comparison.

Expected results:

initialize 'i' iterator with unsigned long so, the compiler doesn't have to take the load for it or doesn't have to cast it at compile time every time.

Comment 1

[xhimanshuz]

I have fix for this bug, can i push it.

Comment 2

[xhimanshuz]

I have fix for this bug, can i push it.

Comment 3

[xhimanshuz]

I have fix for this bug, can i push it.

Comment 4

[Kevin Jacobs [:kjacobs]]

Thanks for the report. Could you please attach your patch above? The current attachment does not seem to contain any changes.

Comment 5

[Kevin Jacobs [:kjacobs]]

Comment on attachment 9073864 [details] [diff] [review]
ec.c

Not a diff/no changes included

Comment 6

[xhimanshuz]

Attachment: ec.c

Warning Fixed file

Comment 7

[xhimanshuz]

(In reply to Kevin Jacobs [:kjacobs] from comment #4)

Thanks for the report. Could you please attach your patch above? The current attachment does not seem to contain any changes.

Done

Comment 8

[J.C. Jones [:jcj] (he/they)]

Comment on attachment 9075882 [details]
ec.c

Note: what we generally expect is the output of `hg diff` -- a patch file, not the whole file.

Comment 9

[Kevin Jacobs [:kjacobs]]

Attachment: ec.patch

Attaching diff of the patched file, r+

Comment 10

[J.C. Jones [:jcj] (he/they)]

https://hg.mozilla.org/projects/nss/rev/c35cf06a60e7655a5ca67eb3e00e43b866a90d9d