1561337 - security/nss/lib/freebl/ecl/ecp_25519.c:88 warning: comparison of integers of different signs: 'int' and 'unsigned long'

Status: RESOLVED FIXED

(NSS :: Build, defect, P2)

Description

[xhimanshuz]

Attachment: ecp_25519.c

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/75.0.3770.100 Safari/537.36

Steps to reproduce:

Build warning noticed while compiling Mozilla-central.
In for loop sizeof(kMethod) produced unsigned long that compare with signed int 'i' that is an iterator.
The compiler will cast 'i' as unsigned long before doing the comparison.

Actual results:

The compiler will cast 'i' as unsigned long before doing the comparison.

Expected results:

initialize 'i' iterator with unsigned long so, the compiler doesn't have to take the load for it or doesn't have to cast it at compile time every time.

Comment 1

[xhimanshuz]

I have fix for this bug, can i push it.

Comment 2

[J.C. Jones [:jcj] (he/they)]

Can you put it up on Phabricator for review, please?
https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html

Comment 3

[xhimanshuz]

(In reply to J.C. Jones [:jcj] (he/him) from comment #2)

Can you put it up on Phabricator for review, please?
https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html

Ok, reading this doc. I will do it with it.

Comment 4

[jbonnafo]

Attachment: Bug 1561337: fix compiler warning

Comment 5

[J.C. Jones [:jcj] (he/they)]

https://hg.mozilla.org/projects/nss/rev/4c771e6a79db809089307ccb72f10fa55f8457e5