Closed Bug 1561337 Opened 2 years ago Closed 2 years ago

security/nss/lib/freebl/ecl/ecp_25519.c:88 warning: comparison of integers of different signs: 'int' and 'unsigned long'

Categories

(NSS :: Build, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: hi.himanshu14, Unassigned)

Details

Attachments

(2 files)

Attached file ecp_25519.c

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/75.0.3770.100 Safari/537.36

Steps to reproduce:

Build warning noticed while compiling Mozilla-central.
In for loop sizeof(kMethod) produced unsigned long that compare with signed int 'i' that is an iterator.
The compiler will cast 'i' as unsigned long before doing the comparison.

Actual results:

The compiler will cast 'i' as unsigned long before doing the comparison.

Expected results:

initialize 'i' iterator with unsigned long so, the compiler doesn't have to take the load for it or doesn't have to cast it at compile time every time.

Summary: security/nss/lib/freebl/ecl/ecp_25519.c:30 warning: comparison of integers of different signs: 'int' and 'unsigned long' → security/nss/lib/freebl/ecl/ecp_25519.c:88 warning: comparison of integers of different signs: 'int' and 'unsigned long'
Priority: -- → P2

I have fix for this bug, can i push it.

(In reply to J.C. Jones [:jcj] (he/him) from comment #2)

Can you put it up on Phabricator for review, please?
https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html

Ok, reading this doc. I will do it with it.

Status: UNCONFIRMED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.51
You need to log in before you can comment on or make changes to this bug.