1561367 - WR capture multiple frames

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Dzmitry Malyshau [:kvark]]

Currently WR captures only a single frame. In some cases, it's difficult to catch a visual issue. Capturing a sequence of frames would help.

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

I'm currently looking at this. It would help greatly with debugging issues such as bug 1526298 and bug 1596460, and no doubt issues in the future.

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1561367 - Implement initial support for capturing multiple frames.

This patch adds support for the capture and replaying of multiple frames
during normal operation of Firefox. Ctrl + Shift + 6 starts capturing
and Ctrl + Shift + 7 stops capturing. It attempts to capture the minimum
amount of data required to replay a sequence for debugging purposes.

There are several known limitations, particularly surrounding replaying
when transitioning between snapshots of the resource cache. These will
be resolved with time, and the current implementation should be workable
to at least capture/debug most animated issues with some effort.

It also adds support for loading dynamic properties which is necessary
for accurate replaying of a captured frame (sequence or individual)
which are in the middle of an animation.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/419be9960357
Implement initial support for capturing multiple frames. r=kvark

Comment 4

[Stefan Hindli [:stefan_hindli]]

Backed out changeset 419be9960357 (Bug 1561367) for causing wrench bustages CLOSED TREE

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=9171c1bb1e9593429d9761b02033e91255f966a3

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=e3fa2adaae1f4357026055791734fe28a5e55a45&selectedJob=298406797

https://treeherder.mozilla.org/logviewer.html#?job_id=298406797&repo=autoland

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1eb600c29550
Implement initial support for capturing multiple frames. r=kvark

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/1eb600c29550