1561376 - moz-phab needs to allow uploading a patch to a revision without commandeering

Status: NEW

(Conduit :: moz-phab, defect, P3)

Description

[Jason Laster [:jlast]]

The debugger team enjoys collaborating with contributors and amongst ourselves. It is common for us to update each other's patches.

In phabricator, that means we're often "commandeering patches" so that we have permission to push to the patches.

There are a couple things that would be nice to tweak:

1. update the copy. Commandeer is a military term that refers to taking something over and I think the language should more closely reflect that we're helping, collaborating. https://www.merriam-webster.com/dictionary/commandeer
2. allow developers with the right level of permission to push to others patches. This is something that github supports and is convenient. It also, supports the idea that we're helping and not taking over someone's work.
3. not swap the reviewer flag. This is similar to point 2, but when we commandeer a contributor's patch it puts them in an awkward position where it is not clear what we expect of them because they do not have permission to approve the PR.

Comment 1

[:glob ✱]

Thanks Jason,

In future please file separate bugs for each individual issue so that can be tracked correctly.

update the copy. Commandeer is a military term that refers to taking something over and I think the language should more closely reflect that we're helping, collaborating. https://www.merriam-webster.com/dictionary/commandeer

This is a WONTFIX - when you commandeer a revision you are indeed taking it over. This is functionally different from collaboration.

allow developers with the right level of permission to push to others patches

Morphing this bug to track this request. It should already be possible with Phabricator, however moz-phab (and/or arc) is likely imposing restrictions here. Bug 1538151 is also relevant here.

not swap the reviewer flag

This is what should happen once point 2 is addressed.