1561385 - Enable ETP cookie tracking restrictions by default for all GV apps

Status: RESOLVED FIXED

(GeckoView :: General, enhancement, P1)

Description

[Chris Peterson [:cpeterson]]

Bug 1554071 will enable ETP by default in Fennec, but not GV. We should enable ETP by default in GV for all GV-powered apps, including third-party apps. They can manually disable ETP if they need to.

Comment 1

[Eugen Sawin [:esawin]]

Attachment: Bug 1561385 - [1.0] Change GeckoView cookie behavior default to block third-party trackers (ETP).

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d191eca319f
[1.0] Change GeckoView cookie behavior default to block third-party trackers (ETP). r=snorp,geckoview-reviewers

Comment 3

[Eugen Sawin [:esawin]]

Chris, can you please communicate the new default up to A-C/Fenix, to make sure they override ContenBlocking.cookieBehavior to their desired default.

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/2d191eca319f

Comment 5

[Chris Peterson [:cpeterson]]

(In reply to Eugen Sawin [:esawin] from comment #3)

Chris, can you please communicate the new default up to A-C/Fenix, to make sure they override ContenBlocking.cookieBehavior to their desired default.

Done: https://github.com/mozilla-mobile/fenix/issues/1749#issuecomment-509517270

We'll want to uplift this fix to GV 69 Beta because that's the next GV version Fenix will pick up.

Do we also need to uplift it to ESR 68 as part of Fennec ETP bug 1554071?

Comment 6

[Eugen Sawin [:esawin]]

(In reply to Chris Peterson [:cpeterson] from comment #5)

(In reply to Eugen Sawin [:esawin] from comment #3)

Chris, can you please communicate the new default up to A-C/Fenix, to make sure they override ContenBlocking.cookieBehavior to their desired default.

Done: https://github.com/mozilla-mobile/fenix/issues/1749#issuecomment-509517270

We'll want to uplift this fix to GV 69 Beta because that's the next GV version Fenix will pick up.

Do we also need to uplift it to ESR 68 as part of Fennec ETP bug 1554071?

This bug changes the cookie settings default, bug 1554071 exposes the new ETP cookie setting in the UI.
We will need to uplift both patches.

Comment 7

[Chris Peterson [:cpeterson]]

(In reply to Eugen Sawin [:esawin] from comment #6)

Do we also need to uplift it to ESR 68 as part of Fennec ETP bug 1554071?

This bug changes the cookie settings default, bug 1554071 exposes the new ETP cookie setting in the UI.
We will need to uplift both patches.

In that case, I will set esr68=affected so we remember to uplift.

After uplifting Fennec ETP to ESR 68, we can let it ride in ESR 68.1 (September 3). I think ETP is a big enough change that it warrants some Fennec beta test time. We don't need to rush it in a Fennec ESR 68.0.x dot release (July).

Comment 8

[Eugen Sawin [:esawin]]

Comment on attachment 9076056 [details]
Bug 1561385 - [1.0] Change GeckoView cookie behavior default to block third-party trackers (ETP).

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Together with bug 1554071, this enables Enhanced Tracking Protection (ETP) by default for Fennec for a consistent privacy policy across platforms.
• User impact if declined: Default cookie behavior would remain in a permissive state, not according to ETP.
• Fix Landed on Version: 70
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It only changes the cookie behavior default.
• String or UUID changes made by this patch: None

Comment 9

[Chris Peterson [:cpeterson]]

69=affected because we'll also want to uplift this ETP default to GV 69 Beta for Fenix.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Can you please request Beta approval for this too?

Comment 11

[Eugen Sawin [:esawin]]

Comment on attachment 9076056 [details]
Bug 1561385 - [1.0] Change GeckoView cookie behavior default to block third-party trackers (ETP).

Beta/Release Uplift Approval Request

See comment 8.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9076056 [details]
Bug 1561385 - [1.0] Change GeckoView cookie behavior default to block third-party trackers (ETP).

Enables ETP by default. Approved for GV69 and Fennec 68.1b2.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e7256a4fce27

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr68/rev/7f7f77e35e3e