Closed Bug 1561407 Opened 4 months ago Closed 3 months ago

Message bar font should match the rest of the page

Categories

(Toolkit :: Add-ons Manager, defect, P2)

defect

Tracking

()

VERIFIED FIXED
mozilla70
Tracking Status
firefox69 --- fixed
firefox70 --- verified

People

(Reporter: mstriemer, Assigned: mstriemer)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

The font for the message-bar component was set up using the fonts from the photon style guide, but they should instead match the font on the rest of the about:addons page.

Pushed by mstriemer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ec30e63fed04
Match message-bar font with other page styles r=rpl
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70

Do we want to uplift this to Beta69 or can it ride the trains? Please nominate the patch for approval if you want to uplift.

Flags: needinfo?(mstriemer)

This issue is Verified as Fixed on Firefox 70.0a1 (20190716001037) on Windows 64- Bit and - MAC os High Sierra 10.13.6 .

Verified against the Firefox 69.0b5 (20190715173502), that the changes to the message bar discopane-notice content, message- bar container, content, body, icon and the spacer element, etc. have been implemented successfully.
An example of the change can be seen on the attached screenshot.

Status: RESOLVED → VERIFIED

Comment on attachment 9073926 [details]
Bug 1561407 - Match message-bar font with other page styles r?rpl!

Beta/Release Uplift Approval Request

  • User impact if declined: Message bars in about:addons will have a small font and not very much padding.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Almost all CSS, one presentation only DOM element added.
  • String changes made/needed:
Flags: needinfo?(mstriemer)
Attachment #9073926 - Flags: approval-mozilla-beta?

Comment on attachment 9073926 [details]
Bug 1561407 - Match message-bar font with other page styles r?rpl!

Improved font rendering for about:addons. Approved for 69.0b6.

Attachment #9073926 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.