1561483 - Bad initialisation of calendar print dialog

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[Geoff Lankow (:darktrojan)]

The print dialog says this on the console when I open it:

NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS: [JavaScript Error: "Cc[settings.layoutCId] is undefined" {file: "chrome://calendar/content/calendar-print-dialog.js" line: 205}]'[JavaScript Error: "Cc[settings.layoutCId] is undefined" {file: "chrome://calendar/content/calendar-print-dialog.js" line: 205}]' when calling method: [calIOperationListener::onOperationComplete]

That's caused by onchange the date pickers firing when they're created. It also seems to be the source of the multiple radio button selection seen in bug 1538688.

I fixed that, but then the date pickers weren't being initialised at all sometimes. What?! It turns out they were trying to run without the menulists inside them ready.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 1561483-print-dialog-init-1.diff

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e0edf0280849
Fix bad initialisation of calendar print dialog. r=philipp

Comment 3

[Jorg K (CEST = GMT+2)]

TB 68 beta 4 / Cal 7.0:
https://hg.mozilla.org/releases/comm-beta/rev/b22a043eaac8fbc3ac3440fe5883cb3c0803825f