Closed Bug 1561556 Opened 1 year ago Closed 1 year ago

Remove -Wmaybe-uninitialized warning in tls13esni.c

Categories

(NSS :: Build, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: giulio.benetti, Assigned: giulio.benetti)

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/74.0.3729.169 Safari/537.36

Steps to reproduce:

make nss_build_all BUILD_OPT=1 ALLOW_OPT_CODE_SIZE=1 OPT_CODE_SIZE=1

Actual results:

tls13esni.c: In function ‘tls13_ClientSetupESNI’:
tls13esni.c:636:31: error: ‘share’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
ss->xtnData.peerEsniShare = share;
^

Expected results:

No warning

This patch fixes described warning.

Assignee: nobody → giulio.benetti
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Priority: -- → P2
Attachment #9074152 - Flags: review?(jjones)
Comment on attachment 9074152 [details] [diff] [review]
0001-Bug-1561556-Remove-Wmaybe-uninitialized-warning-in-t.patch

Moving to Marcus (hope you don't mind!)
Attachment #9074152 - Flags: review?(jjones) → review?(marcus.apb)
Comment on attachment 9074152 [details] [diff] [review]
0001-Bug-1561556-Remove-Wmaybe-uninitialized-warning-in-t.patch

Review of attachment 9074152 [details] [diff] [review]:
-----------------------------------------------------------------

Hi Giulio,

This patch looks complete for this bug.

Thanks,
Attachment #9074152 - Flags: review?(marcus.apb) → review+
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 3.46
You need to log in before you can comment on or make changes to this bug.