1561558 - Remove -Wmaybe-uninitialized warning in httpserv.c

Status: RESOLVED FIXED

(NSS :: Build, defect, P2)

Description

[Giulio Benetti]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/74.0.3729.169 Safari/537.36

Steps to reproduce:

make nss_build_all BUILD_OPT=1 ALLOW_OPT_CODE_SIZE=1 OPT_CODE_SIZE=1

Actual results:

httpserv.c: In function ‘handle_connection.isra.1’:
httpserv.c:747:32: error: ‘isPost’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
if (!isPost && ocspMethodsAllowed == ocspGetUnknown) {
^

Expected results:

No warning.

Comment 1

[Giulio Benetti]

Attachment: 0001-Bug-1561558-Remove-Wmaybe-uninitialized-warning-in-h.patch

This patch fixes the warning.

Comment 2

[Marcus Burghardt]

Hi Giulio,

Thanks to report and already send a patch.
This fix looks good.

Could you use moz-phg to send this patch, please?

Thanks,

Comment 3

[Marcus Burghardt]

Comment on attachment 9074153 [details] [diff] [review]
0001-Bug-1561558-Remove-Wmaybe-uninitialized-warning-in-h.patch

Review of attachment 9074153 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks

Comment 4

[J.C. Jones [:jcj] (he/they)]

https://hg.mozilla.org/projects/nss/rev/ca6665a8459d89e423946cc1c9b9c8ae41ba5318