1561591 - Remove -Wmaybe-uninitialized warning in tstclnt.c

Status: RESOLVED FIXED

(NSS :: Build, defect, P2)

Description

[Giulio Benetti]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/74.0.3729.169 Safari/537.36

Steps to reproduce:

make nss_build_all BUILD_OPT=1 ALLOW_OPT_CODE_SIZE=1 OPT_CODE_SIZE=1
but using -Og flag instead of -Os.

Actual results:

In file included from ../../../dist/public/nss/seccomon.h:16,
from ../../../dist/private/nss/secutil.h:7,
from tstclnt.c:11:
tstclnt.c: In function ‘restartHandshakeAfterServerCertIfNeeded’:
../../../dist/public/nss/utilrename.h:65:23: error: ‘error’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
#define PORT_SetError PORT_SetError_Util
^~~~~~~~~~~~~~~~~~
tstclnt.c:920:17: note: ‘error’ was declared here
PRErrorCode error;
^~~~~

Expected results:

No warning.

Comment 1

[Giulio Benetti]

Attachment: 0008-Bug-1561591-Remove-Wmaybe-uninitialized-warning-in-t.patch

This patch fixes the warning.

Comment 2

[Kevin Jacobs [:kjacobs]]

Comment on attachment 9074167 [details] [diff] [review]
0008-Bug-1561591-Remove-Wmaybe-uninitialized-warning-in-t.patch

Review of attachment 9074167 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 3

[J.C. Jones [:jcj] (he/him)]

https://hg.mozilla.org/projects/nss/rev/a403ab652b8ce03a41a6a8eef99953d061e7a906