1561598 - Remove -Wmaybe-uninitialized warning in pqg.c

Status: RESOLVED FIXED

(NSS :: Build, defect, P2)

Description

[Giulio Benetti]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/74.0.3729.169 Safari/537.36

Steps to reproduce:

make nss_build_all BUILD_OPT=1 ALLOW_OPT_CODE_SIZE=1 OPT_CODE_SIZE=1 NSS_BUILD_SOFTOKEN_ONLY=1

Actual results:

pqg.c: In function ‘PQG_VerifyParams’:
pqg.c:1806:27: error: ‘type’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
if ((vfy->h.len == 1) && (type != FIPS186_1_TYPE)) {
^
In file included from pqg.c:21:0:
secmpi.h:8:8: error: ‘hashtype’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
if (SECSuccess != (rv = func))
^
pqg.c:1624:19: note: ‘hashtype’ was declared here
HASH_HashType hashtype;
^
cc1: all warnings being treated as errors

Expected results:

No warnings at all.

Comment 1

[Giulio Benetti]

Attachment: 0001-Bug-1561598-Remove-Wmaybe-uninitialized-warning-in-p.patch

This patch fixes the warning.

Comment 2

[Marcus Burghardt]

Comment on attachment 9074171 [details] [diff] [review]
0001-Bug-1561598-Remove-Wmaybe-uninitialized-warning-in-p.patch

Hi Giulio,

Thanks to inform and suggest a fix.
There are other places where this variable can be initialized too.
https://searchfox.org/mozilla-central/source/security/nss/lib/freebl/pqg.c#893
https://searchfox.org/mozilla-central/source/security/nss/lib/freebl/pqg.c#1242
https://searchfox.org/mozilla-central/source/security/nss/lib/freebl/pqg.c#1633

Could you update the patch, please?
It would be better if you send the patch using moz-php.
https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html

Thanks,

Comment 3

[Marcus Burghardt]

Comment on attachment 9074171 [details] [diff] [review]
0001-Bug-1561598-Remove-Wmaybe-uninitialized-warning-in-p.patch

Review of attachment 9074171 [details] [diff] [review]:
-----------------------------------------------------------------

There are other places with the same variable that should be fixed together.

Comment 4

[Giulio Benetti]

Attachment: v2-0001-Bug-1561598-Remove-Wmaybe-uninitialized-warning-in-p.patch

Comment 5

[Giulio Benetti]

Hi Marcus,

above is the patch requested with no newline. I attach a new one. Sorry.

Comment 6

[Giulio Benetti]

(In reply to Giulio Benetti from comment #5)

Hi Marcus,

above is the patch requested with no newline. I attach a new one. Sorry.

Nope, it's ok as it is.

Comment 7

[Giulio Benetti]

Kindly ping.

Comment 8

[Marcus Burghardt]

Comment on attachment 9078361 [details] [diff] [review]
v2-0001-Bug-1561598-Remove-Wmaybe-uninitialized-warning-in-p.patch

Thanks Giulio.

Comment 9

[J.C. Jones [:jcj] (he/him)]

https://hg.mozilla.org/projects/nss/rev/caf5d97f786fc3dad2f9318b228007a233b5f0bd

Comment 10

[J.C. Jones [:jcj] (he/him)]

Thanks again Giulio for these patches!

Comment 11

[Giulio Benetti]

You're welcome, it's been a pleasure contributing with these patches :)