Font Editor: simplify handling of font variation instances
Categories
(DevTools :: Inspector, task, P3)
Tracking
(firefox69 fixed)
Tracking | Status | |
---|---|---|
firefox69 | --- | fixed |
People
(Reporter: rcaliman, Assigned: rcaliman)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Slightly refactor the Font Editor Redux actions and reducer to remove indirection from the handling of font variation instances when supported on variable fonts.
This simplifies the code and remove some needless async operation.
Assignee | ||
Comment 1•5 years ago
|
||
The Redux action/reducer setup for handling selecting and applying font variation instances is needlessly complex. The indirection is not necessary.
The flow is as follows:
-
When a font variation instance (provided by some variable font files) is selected from the Instances select menu, update all variation axes with the values associated with that instance.
-
When the user makes any manual change to any of the axis values, save all axis values associated with a "Custom" variation instance. This enables the user to revert to them.
This patch removes the needless indirection about saving the axis values and applying the "Custom" variation instance. The logic is now moved to the UPDATE_AXIS_VALUE reducer.
Pushed by rcaliman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5f0520d9b5de Simplify handling for font variation instances in Font Editor. r=gl
Comment 3•5 years ago
|
||
Backed out changeset 5f0520d9b5de (bug 1561639) for ESlint failure
Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=253693175&repo=autoland&lineNumber=295
Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=253693175&revision=5f0520d9b5dedf9e41b64862f1df0507063f4c37
Backout:
Backout by dluca@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2f1699730633 Backed out changeset 5f0520d9b5de for ESlint failure
Pushed by rcaliman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/666a43a4ae84 Simplify handling for font variation instances in Font Editor. r=gl
Comment 7•5 years ago
|
||
bugherder |
Updated•3 years ago
|
Description
•