1561676 - WebSocket panel crashes in WebConsole

Status: RESOLVED FIXED

(DevTools :: Console, defect, P2)

Description

[Christoph Walcher]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:69.0) Gecko/20100101 Firefox/69.0

Steps to reproduce:

1. Enable 'Requests' in WebConsole
2. Select request which is a WebSocket connection
3. Select 'WebSocket' Tab

Actual results:

   {
  "id": "server1.conn2.netEvent892",
  "actor": "server1.conn2.netEvent892",
  "level": "log",
  "isXHR": false,
  "request": {
    "url": "https://s-usc1c-nss-210.firebaseio.com/...",
    "method": "GET",
    "headersSize": 515
  },
  "response": {
    "httpVersion": "HTTP/1.1",
    "status": "101",
    "statusText": "Switching Protocols",
    "headersSize": 254,
    "remoteAddress": "2600:1901:0:94b6::",
    "remotePort": 443,
    "content": {
      "mimeType": "text/plain"
    },
    "bodySize": 0,
    "transferredSize": 254
  },
  "source": "network",
  "type": "log",
  "groupId": null,
  "timeStamp": 1561571288618,
  "indent": 0,
  "updates": [
    "requestHeaders",
    "requestCookies",
    "responseStart",
    "eventTimings",
    "securityInfo",
    "responseHeaders",
    "responseCookies",
    "responseContent"
  ],
  "openedOnce": true,
  "securityInfo": null,
  "requestHeadersFromUploadStream": null,
  "private": false,
  "url": "https://s-usc1c-nss-210.firebaseio.com/....",
  "urlDetails": {
    "baseNameWithQuery": "...",
    "host": "s-usc1c-nss-210.firebaseio.com",
    "scheme": "https",
    "unicodeUrl": "https://s-usc1c-nss-210.firebaseio.com/....",
    "isLocal": null,
    "url": "https://s-usc1c-nss-210.firebaseio.com/.,,"
  },
  "method": "GET",
  "cause": {
    "type": "websocket",
    "loadingDocumentUri": "file:///Users/christophwalch...",
    "stacktraceAvailable": false
  },
  "lastExecutionPoint": {
    "point": {
      "checkpoint": 0,
      "progress": 0
    },
    "messageCount": 12
  }
}

console.error: (new TypeError("state.webSockets is undefined", "resource://devtools/client/netmonitor/src/selectors/web-sockets.js", 8))

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

@Heng Yeow: can you please take a look at this?

Honza

Comment 2

[Hengyeow (:tanhengyeow)]

The WebSocketsPanel reaches out to the netmonitor's state to fetch WebSocket frames for display in the panel.

I believe the state is not available in the console panel when WebSocketsPanel is displayed through the console, thus the error. After discussion with @nchevobbe through Slack, the consensus was to not show WebSocketsPanel in the console panel for now until we figure out a good solution to get the data in the WebSocketsPanel. Will be submitting a patch for this.

Comment 3

[Hengyeow (:tanhengyeow)]

Attachment: Bug 1561676 - WebSocket panel crashes in WebConsole. r=nchevobbe, Honza

Hide WebSocketsPanel in console.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/89d1a2584683
WebSocket panel crashes in WebConsole. r=nchevobbe,Honza

Comment 5

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/89d1a2584683