Closed
Bug 1561749
Opened 5 years ago
Closed 5 years ago
Link Rust programs with Windows resources
Categories
(Firefox Build System :: General, enhancement)
Tracking
(firefox70 fixed)
RESOLVED
FIXED
mozilla70
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: agashlin, Assigned: agashlin)
References
Details
Attachments
(1 file)
Programs built with RUST_PROGRAMS don't currently make use of the RESFILE variable, so they don't get the default metadata that existing binaries come with.
The RESFILE variable specifies the name of a compiled resource file to be linked into the binary, as the result of compiling any existing .res or .rc files. If RESFILE is not given (the common case), then version.mk will provide a default module.rc with version metadata, and RESFILE is set to module.res. So as long as $(RESFILE) is a prerequisite for the target (as it is for PROGRAM) it will get some resource built. This then needs to be included in the link.
Patch incoming.
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Updated•5 years ago
|
Attachment #9074372 -
Flags: feedback?(nfroyd)
|
||
Updated•5 years ago
|
Attachment #9074372 -
Flags: feedback?(nfroyd) → feedback+
Pushed by agashlin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0873b1c9bca7
Link Rust programs with Windows resources. r=froydnj
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in
before you can comment on or make changes to this bug.
Description
•