Closed Bug 1561755 Opened 3 months ago Closed 3 months ago

Use the inline-flex tooltip text for the inline-flex badge

Categories

(DevTools :: Inspector, task, P3)

task

Tracking

(firefox69 fixed)

RESOLVED FIXED
Firefox 69
Tracking Status
firefox69 --- fixed

People

(Reporter: gl, Assigned: vanhagarsux, Mentored)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

In https://searchfox.org/mozilla-central/source/devtools/client/inspector/markup/views/element-editor.js#37, we are mistakenly using the flex display badge tooltip when we should be using markupView.display.inlineFlex.tooltiptext that is already defined in https://searchfox.org/mozilla-central/source/devtools/client/locales/en-US/inspector.properties#45.

The changes required here would be to simply replace the string with the correct inlineFlex tooltip string id.

Bugbug thinks this bug is a task, but please change it back in case of error.

Type: defect → task

Hi Gabriel,

This looks like a good second bug to tackle. Could I get assigned this?

Thanks,
J

Assignee: nobody → vanhagarsux
Status: NEW → ASSIGNED

Hi Gabriel,

I've created a patch and I'm now looking for a review. Should I add you as a reviewer to my commit message?

Thanks,
J

(In reply to J from comment #3)

Hi Gabriel,

I've created a patch and I'm now looking for a review. Should I add you as a reviewer to my commit message?

Thanks,
J

Yes, please do. Thanks!

In element-editor.js, line #37, the flex display badge tooltip has been removed and replaced with the
correct inlineFlex tooltip string id, "markupView.display.inlineFlex.tooltiptext", which has already
been defined in inspector.properties, line #45.

Attachment #9075271 - Attachment is obsolete: true
Attachment #9075271 - Attachment is obsolete: false
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/34736dcd7f1c
Replace flex display badge tooltip with the correct inlineFlex tooltip string id in element-editor.js. r=gl
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69
You need to log in before you can comment on or make changes to this bug.