1561755 - Use the inline-flex tooltip text for the inline-flex badge

Status: RESOLVED FIXED

(DevTools :: Inspector, task, P3)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

In https://searchfox.org/mozilla-central/source/devtools/client/inspector/markup/views/element-editor.js#37, we are mistakenly using the flex display badge tooltip when we should be using markupView.display.inlineFlex.tooltiptext that is already defined in https://searchfox.org/mozilla-central/source/devtools/client/locales/en-US/inspector.properties#45.

The changes required here would be to simply replace the string with the correct inlineFlex tooltip string id.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a task, but please change it back in case of error.

Comment 2

[J]

Hi Gabriel,

This looks like a good second bug to tackle. Could I get assigned this?

Thanks,
J

Comment 3

[J]

Hi Gabriel,

I've created a patch and I'm now looking for a review. Should I add you as a reviewer to my commit message?

Thanks,
J

Comment 4

[Gabriel Luong [:gl] (ΦωΦ)]

(In reply to J from comment #3)

Hi Gabriel,

I've created a patch and I'm now looking for a review. Should I add you as a reviewer to my commit message?

Thanks,
J

Yes, please do. Thanks!

Comment 5

[J]

Attachment: Bug 1561755 - Replace flex display badge tooltip with the correct inlineFlex tooltip string id in element-editor.js. r=gl

In element-editor.js, line #37, the flex display badge tooltip has been removed and replaced with the
correct inlineFlex tooltip string id, "markupView.display.inlineFlex.tooltiptext", which has already
been defined in inspector.properties, line #45.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/34736dcd7f1c
Replace flex display badge tooltip with the correct inlineFlex tooltip string id in element-editor.js. r=gl

Comment 7

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/34736dcd7f1c