1561953 - Multiple definitions of libVersionPoint

Status: RESOLVED FIXED

(NSPR :: NSPR, defect, P1)

Description

[Edouard Oger [:eoger]]

When statically linking our lib with NSS, I'm getting the follow error on Linux:

/home/circleci/project/libs/desktop/linux-x86-64/nss/lib/libplc4.a(plvrsion.o): In function `libVersionPoint':
          plvrsion.c:(.text+0x0): multiple definition of `libVersionPoint'
          /home/circleci/project/libs/desktop/linux-x86-64/nss/lib/libnspr4.a(prvrsion.o):prvrsion.c:(.text+0x0): first defined here
          /home/circleci/project/libs/desktop/linux-x86-64/nss/lib/libplds4.a(plvrsion.o): In function `libVersionPoint':
          plvrsion.c:(.text+0x0): multiple definition of `libVersionPoint'
          /home/circleci/project/libs/desktop/linux-x86-64/nss/lib/libnspr4.a(prvrsion.o):prvrsion.c:(.text+0x0): first defined here
          collect2: error: ld returned 1 exit status

Comment 1

[J.C. Jones [:jcj] (he/they)]

Looks like that's coming out of NSPR -- Did this just start happening?

Comment 2

[Edouard Oger [:eoger]]

I'm guessing it was always here, we haven't had a chance to test static linkage on Linux yet (on macOS I believe there's a bug in rustc where it doesn't tell you when there's duplicate symbols).

Comment 3

[Edouard Oger [:eoger]]

Attachment: Bug 1561953 - Filter out PR version files in static library build.

Comment 4

[Edouard Oger [:eoger]]

Mike I've updated the patch with a different approach as we discussed on Zoom, let us know if that's acceptable.

Comment 5

[Edouard Oger [:eoger]]

Patch updated with the review comments addressed

Comment 6

[Edouard Oger [:eoger]]

Thanks for the review!

Comment 7

[J.C. Jones [:jcj] (he/they)]

https://hg.mozilla.org/projects/nspr/rev/bf5c37749c28c523134e41b1e28b6ffaf2d2c4e9