Closed Bug 1561953 Opened 1 year ago Closed 1 year ago

Multiple definitions of libVersionPoint

Categories

(NSPR :: NSPR, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: eoger, Assigned: eoger)

References

Details

(Whiteboard: staticlink)

Attachments

(1 file)

When statically linking our lib with NSS, I'm getting the follow error on Linux:

/home/circleci/project/libs/desktop/linux-x86-64/nss/lib/libplc4.a(plvrsion.o): In function `libVersionPoint':
          plvrsion.c:(.text+0x0): multiple definition of `libVersionPoint'
          /home/circleci/project/libs/desktop/linux-x86-64/nss/lib/libnspr4.a(prvrsion.o):prvrsion.c:(.text+0x0): first defined here
          /home/circleci/project/libs/desktop/linux-x86-64/nss/lib/libplds4.a(plvrsion.o): In function `libVersionPoint':
          plvrsion.c:(.text+0x0): multiple definition of `libVersionPoint'
          /home/circleci/project/libs/desktop/linux-x86-64/nss/lib/libnspr4.a(prvrsion.o):prvrsion.c:(.text+0x0): first defined here
          collect2: error: ld returned 1 exit status

Looks like that's coming out of NSPR -- Did this just start happening?

Priority: -- → P1
Whiteboard: staticlink

I'm guessing it was always here, we haven't had a chance to test static linkage on Linux yet (on macOS I believe there's a bug in rustc where it doesn't tell you when there's duplicate symbols).

See Also: → 838566
Attachment #9074872 - Attachment description: Bug 1561953 - Add NO_PR_VERSION define. → Bug 1561953 - Filter out PR version files in static library build.

Mike I've updated the patch with a different approach as we discussed on Zoom, let us know if that's acceptable.

Flags: needinfo?(mh+mozilla)
Flags: needinfo?(mh+mozilla)

Patch updated with the review comments addressed

Flags: needinfo?(mh+mozilla)

Thanks for the review!

Assignee: nobody → eoger
Status: NEW → ASSIGNED
Flags: needinfo?(mh+mozilla)
Keywords: checkin-needed
Component: Build → NSPR
Product: NSS → NSPR
QA Contact: jjones
Version: trunk → other
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 4.22
You need to log in before you can comment on or make changes to this bug.