1562084 - Description for non proxy-ing localhost

Status: RESOLVED FIXED

(Firefox :: Settings UI, enhancement)

Description

[Junior [inactive]]

(In reply to :Gijs (he/him) from comment #24)

There were at least 7 bugs filed about this behaviour (see bug 1535581 and dupes) since it hit release. That's quite a lot.

Junior, should we consider adding some text underneath the box that says something to the effect of "localhost never uses the proxy"?

Comment 1

[:Gijs (he/him)]

We need a text. Right now it says:

No Proxy for
[field goes here]
Example: .mozilla.org, .net.nz, 192.168.1.0/24

I would suggest that we add a second line under the example that says "Connections to localhost, 127.0.0.1, and ::1 are never proxied", iff the magic about:config pref is not set.

We probably want to add some vertical spacing after that text to ensure it's clear it applies to the "no proxy for" textbox. How does that sound?

(I would normally ask Meridel to help with the text, but this is so technical / niche / seen by so few people, that I'm not sure it's worth her spending time on it.)

Comment 2

[Junior [inactive]]

I'm with you with the text and space.
To confirm:
You don't want to show the second line if the magic pref is not set?

Comment 3

[Junior [inactive]]

Oh I see the "iff"

Comment 4

[Junior [inactive]]

Attachment: Bug 1562084 - Description for non proxy-ing localhost

Comment 5

[Junior [inactive]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4dc6a6e03e3c8da6fab37b4f978e8b5f24bc9d27

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/654b39942f88
Description for non proxy-ing localhost r=fluent-reviewers,Gijs,flod

Comment 7

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/654b39942f88