Closed Bug 1562084 Opened 4 months ago Closed 4 months ago

Description for non proxy-ing localhost

Categories

(Firefox :: Preferences, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 69
Tracking Status
firefox69 --- fixed

People

(Reporter: junior, Assigned: junior)

References

Details

Attachments

(1 file)

(In reply to :Gijs (he/him) from comment #24)

There were at least 7 bugs filed about this behaviour (see bug 1535581 and dupes) since it hit release. That's quite a lot.

Junior, should we consider adding some text underneath the box that says something to the effect of "localhost never uses the proxy"?

We need a text. Right now it says:

No Proxy for
[field goes here]
Example: .mozilla.org, .net.nz, 192.168.1.0/24

I would suggest that we add a second line under the example that says "Connections to localhost, 127.0.0.1, and ::1 are never proxied", iff the magic about:config pref is not set.

We probably want to add some vertical spacing after that text to ensure it's clear it applies to the "no proxy for" textbox. How does that sound?

(I would normally ask Meridel to help with the text, but this is so technical / niche / seen by so few people, that I'm not sure it's worth her spending time on it.)

Flags: needinfo?(juhsu)

I'm with you with the text and space.
To confirm:
You don't want to show the second line if the magic pref is not set?

Flags: needinfo?(juhsu) → needinfo?(gijskruitbosch+bugs)

Oh I see the "iff"

Flags: needinfo?(gijskruitbosch+bugs)
Summary: Description in for non proxy-ing localhost → Description for non proxy-ing localhost
Pushed by juhsu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/654b39942f88
Description for non proxy-ing localhost r=fluent-reviewers,Gijs,flod
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69
You need to log in before you can comment on or make changes to this bug.