1562086 - [fill-stroke] [filter-effects] [css-color] percentage opacity

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P2)

Description

[Mozilla Apprentice]

A resolution was made for csswg-drafts/#3342.

[fill-stroke] [filter-effects] [css-color] percentage opacity

• RESOLVED: No change to spec

Discussion.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

We should probably prioritize adding percentage opacity (in all the places it's allowed) relatively highly since once other engines add it, we're likely to start hitting compat problems reasonably quickly. It should also be pretty simple to do.

Comment 2

[Boris Chiou [:boris]]

This bug will use <alpha-value> for these properties:

1. opacity
2. flood-opacity
3. fill-opacity
4. stroke-opacity
5. stop-opacity
6. -moz-window-opacity

-moz-window-opacity uses Opacity type, so for consistency, I will also update it.

Test: https://jsfiddle.net/ericwilligers/zmgy8735/

Comment 3

[Boris Chiou [:boris]]

Attachment: Bug 1562086 - Add percentage for opacity (i.e. <alpha-value>).

The following properties accept <alpha-value> [1], which is
"<number> | <percentage>", so we update the parser, spec links, and
their web-platform-tests.

1. opacity
2. flood-opacity
3. fill-opacity
4. stroke-opacity
5. stop-opacity
6. -moz-window-opacity

Besides, shape-image-threshold [2] still only accepts <number>, so we need
to support a different version of Opacity::parse().

[1] https://drafts.csswg.org/css-color/#typedef-alpha-value
[2] https://drafts.csswg.org/css-shapes/#shape-image-threshold-property

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/abe58536c427
Add percentage for opacity (i.e. <alpha-value>). r=emilio

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/17817 for changes under testing/web-platform/tests

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/abe58536c427

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged

Comment 9

[Chris Mills [:cmills]]

Documented as per https://github.com/mdn/sprints/issues/2084