Closed Bug 1562328 Opened 3 months ago Closed 2 months ago

Add 'sign in to sync' button and message at the top of about:logins

Categories

(Toolkit :: Password Manager, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
mozilla70
Tracking Status
firefox70 --- verified

People

(Reporter: jaws, Assigned: jaws, NeedInfo)

References

(Blocks 1 open bug)

Details

(Whiteboard: [passwords:management] [skyline])

Attachments

(4 files)

When clicked, we should launch the sign in page in a new tab instead of routing to the preferences.

If the user is signed in, we should show their avatar as well as their email address. Clicking on their avatar should open a new tab to the preferences for managing Sync and disconnecting.

Flags: qe-verify+
Whiteboard: [passwords:management] [skyline]
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Attachment #9077980 - Attachment description: Bug 1562328 - WIP sign in to sync button → Bug 1562328 - Custom element for Sync button in header of about:logins. r?MattN

Has there been any UX input here? I know that Ryan Feeley is looking to change about:preferences#sync to avoid the "create acct" and "sign in" buttons, replacing them with something like "Sign in to Sync", all towards a future where "sync" and a "firefox account" are decoupled for other account related services. I imagine he's going to want some consistency here with about:preferences#sync (eg, why is the 'display name' not shown?).

I've CC'd him here (along with Ryan Kelly who's also involved in the "decoupling" work), but could you please attach a screen-shot of your current patch and then needinfo :rfeeley for feedback?

This is the spec for the "Sign in to Sync" button,
https://mozilla.invisionapp.com/share/EJRHBMEDKF8#/screens/372727457

This is the spec for when login sync is disabled,
https://mozilla.invisionapp.com/share/EJRHBMEDKF8#/screens/372087061

This is the spec for when the account is signed in and login sync is enabled,
https://mozilla.invisionapp.com/share/EJRHBMEDKF8#/screens/372931540

Thanks Jaws. Ryan, you OK with that given the changes you've been discussing recently?

Flags: needinfo?(rfeeley)
Blocks: 1568359
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a1a0bd5471ba
Custom element for Sync button in header of about:logins. r=fluent-reviewers,MattN,Pike,lina
https://hg.mozilla.org/integration/autoland/rev/bdc4220a6930
Hook up Sync's UIState and login sharing pref to Sync button custom element. r=MattN,fluent-reviewers,markh,Pike
https://hg.mozilla.org/integration/autoland/rev/9f2e60fb1dcd
Hook up the enable and options Sync buttons to their respective sites. r=MattN,lina
https://hg.mozilla.org/integration/autoland/rev/11de4b3dec2b
Add https to the img-src in the CSP to allow for displaying Sync avatars. r=MattN,markh
Depends on: 1570346

I have verified this issue on the latest Nightly 70.0a1 (2019-08-01) (64-bit) on Windows 10, MacOS 10.14 and Ubuntu 18.04.

  • The "Sign in to Sync" button and the message is displayed on the top of about:logins page.
  • When click on the "Sign in to Sync" button it redirects you on the Sign In FxA page in a new tab.
  • After you logged in, on the about:login page the "Sign in to Sync" button is replaced by email address + avatar.
  • If the avatar is clicked you are redirected to the manage FxA account page.
Status: RESOLVED → VERIFIED
Flags: qe-verify+

Is there still time to update capitalization on the string? It should read Sign In to Sync

My fault for not catching this sooner. The word “In” should capped here because "Sign In" functions here as a compound verb, and "in" does not stand alone as a preposition.

Without wanting to derail fixing this string in particular, it's worth noting we're fairly inconsistent here - https://searchfox.org/mozilla-central/search?q=sign%20in%20to

It's an inconsistency I'd very much like to fix. Would you recommend I file bugs for those other instances?

This would not apply to full sentences that use the phrase "Sign in to," but for buttons only. For example, Create or sign in to your { -fxaccount-brand-name } on the device where your logins are saved would remain as-is.

Can you please file bugs for these other ones, including a new bug to get the capitalization fixed for the string from this one? Feel free to leave links to the new bugs you file here.

Flags: needinfo?(bmikel)
You need to log in before you can comment on or make changes to this bug.