1562453 - [-Werror,-Wtautological-type-limit-compare] Useless test - "is always false"

Status: RESOLVED FIXED

(Core :: WebVR, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

The CI with -Werror is failing since bug 1466702 landed.
The warning is:

/var/lib/jenkins/workspace/firefox-clang-lld-last/dom/vr/VRServiceTest.cpp:635:17: error: result of comparison 'uint32_t' (aka 'unsigned int') > 4294967295 is always false [-Werror,-Wtautological-type-limit-compare]
  if (aDuration > 0xffffffff) {
      ~~~~~~~~~ ^ ~~~~~~~~~~
/var/lib/jenkins/workspace/firefox-clang-lld-last/dom/vr/VRServiceTest.cpp:644:17: error: result of comparison 'uint32_t' (aka 'unsigned int') > 4294967295 is always false [-Werror,-Wtautological-type-limit-compare]
  if (aDuration > 0xffffffff) {
      ~~~~~~~~~ ^ ~~~~~~~~~~

Kip, could you please have a look? Thanks

Comment 1

[:kip (Kearwood Gilbert)]

Attachment: Bug 1562453 - Remove uint32 clamping tests, which have no effect

There were a couple of checks to clamp arguments in VRServiceTest.cpp.
The final landed patch reduced the arguments to 32-bit unsigned
integers, making these checks redundant.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f1b37c88772
Remove uint32 clamping tests, which have no effect r=thomasmo

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/6f1b37c88772

Comment 4

[:kip (Kearwood Gilbert)]

Clearing NI

Comment 5

[Sylvestre Ledru [:Sylvestre]]

thanks!