1562479 - Phabricator always requests re-upload of large binary files

Status: NEW

(Conduit :: Phabricator, enhancement, P3)

Description

[Ian Moody [:Kwan] (UTC+0)]

hg add someImageOver8MiB.png
hg add smallImage.png
hg commit -m "Ignore: test"
arc diff --trace

Observe two file.allocate calls, the file.uploadchunk calls for the large image, and the file.upload call for the small one

echo test > test
hg add test
hg amend
arc diff --trace

observe two file.allocate calls again, another set of file.uploadchunk calls, but no file.upload, because the small image hasn't changed, and when Phab receives the contentLength and contentHash data in the file.allocate call it recognises that it has it and the result specifies not to upload it:

{
  "upload": false,
  "filePHID": "PHID-FILE-whatever"
}

It should do the same for the large file, rather than returning "upload": true with a new filePHID.