156255 - crash on exit/close/quit in offline mode

Status: RESOLVED DUPLICATE of bug 156581

(SeaMonkey :: General, defect)

Description

[Rene ALBERT]

I am under
Mozilla 1.1a+
Mozilla/5.0 (Windows; U; Win95; en-US; rv:1.1a+) Gecko/20020704

Whenever I close Mozilla - and once it has been closed - Windows diaplays an
Alert message saying :
"This program is going to be stopped because it has performed an invalid operation.
"Details : Page fault in module MSVCRT.DLL at 024f:7800dlb9

and so on.
On my C disk, I still have 411 Mo available.

Comment 1

[Rene ALBERT]

Important remark : this bug appears only if I start Mozilla in off-line mode,
and then I remain off-line until I close Moz.

When I start in on-line mode, and stay in on-line mode until I close Moz, no bug
appears ...

Comment 2

[Tuukka Tolvanen (sp3000)]

confirmed linux trunk cvs 2002-07-08; 2002-06-24 trunk cvs wfm. Start, new
profile, switch to offline, file>quit -> crash.

Comment 3

[Tuukka Tolvanen (sp3000)]

Attachment: assertions and gdb bt from debug trunk cvs 2002-07-08

Comment 4

[Tuukka Tolvanen (sp3000)]

->net sounds good to me

Comment 5

[Tuukka Tolvanen (sp3000)]

Apparently we go offline on shutdown even when we are already offline, and
    // clear the hostname database (NOTE: this runs when the browser
    // enters the offline state).
    PL_DHashTableFinish(&mHostDB);
on both occasions, the latter of which crashes. The lines were added in bug
149943, +cc darin.

I'll attach a patch that moves the lines inside the |if (mThread)| block so it
doesn't get run when going offline when already offline. I'm not sure if this is
the right fix, considering the NS_NOTREACHED adornment of |if (mThread)|'s
else-side. It does fix the crash though.

Comment 6

[Tuukka Tolvanen (sp3000)]

Attachment: patch

Comment 7

[Rene ALBERT]

I am unfortunately obliged to modify my previous addendum : I also got crashes
now when leaving Moz from on-line mode.
No explanation why this occurs now, and from the very beginning of my test ... 

Comment 8

[benc]

-> browser-general. Please get talkback data. If it is networking, then move
this bug back.

Comment 9

[Rene ALBERT]

This is the message displayed bu Windows AFTER Moz has been closed.
Therefore there is no Talkback initiated....
______________________________________________
MOZILLA a causé une défaillance de page dans
 le module MSVCRT.DLL à 024f:7800d0b9.
Registres :
EAX=02e11fc0 CS=024f EIP=7800d0b9 EFLGS=00010283
EBX=0ae0ffff SS=0257 ESP=0064fba4 EBP=0064fbc0
ECX=fffefffe DS=0257 ESI=0347f008 FS=0e5f
EDX=51580000 ES=0257 EDI=00000017 GS=0000
Octets à CS : EIP :
89 5a 04 8b 55 0c 89 4d fc 8b 5a 04 8b 52 08 89 
Etat de la pile :
007b8208 0347f00c 03478280 02e14f60 ffff0000 00000000 fffffffe 0064fc04 7800cc1c
007600fc 0347f006 007b8208 03478280 03478280 7800578c 033dfd50 

Comment 10

[Daniel Veditz [:dveditz]]

Sorry we didn't notice this bug or patch earlier. It's also been fixed in the
bug I'm duping this against. Darin's on sabbatical, we're doing the best we can
to cover.

Who is "[e-mail]" ?

*** This bug has been marked as a duplicate of 156581 ***