1562724 - “execute getter” not working in Preview

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[David Walsh :davidwalsh]

STR:

1. Go to https://codepen.io/anon/pen/JQLORP
2. Click “increment” (Pauses)
3. Hover over “this”
4. Click the “>>” next to “$listeners”

Expected:

The arrows go away and you get a value

Actual:

Nothing happens

The “>>” does work properly in the scopes pane, however.

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I can reproduce this on my machine, thanks for the report David.

Honza

Comment 2

[Stepan Stava [:stepan]]

Hi, is this one still available? I'd like to take it.

Comment 3

[Stepan Stava [:stepan]]

Attachment: Bug 1562724 - Fix "execute getter" button in Debugger Preview popup. r=nchevobbe.

The 'getter button' doesn't work correctly only on the root level items in the 'Popup' element. Any items on depth 1+ display values correctly.

I added a check if a root item has any corresponding 'evaluation' from the 'getter executing', and if so the root item gets that 'evaluation'.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a4d1d2c08331
Fix "execute getter" button in Debugger Preview popup. r=nchevobbe.

Comment 5

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/a4d1d2c08331

Comment 6

[Nicolas Chevobbe [:nchevobbe][PTO - back January 2nd]]

🎉 thanks a lot Stepan!

Comment 7

[Stepan Stava [:stepan]]

Thanks for the help Nicolas!