Closed Bug 1562724 Opened 4 years ago Closed 3 years ago

“execute getter” not working in Preview

Categories

(DevTools :: Debugger, defect, P3)

Product:
DevTools
Component:
Debugger
Type:
defect

Tracking

(firefox75 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 75
Tracking Flags:
Tracking Status
firefox75 --- fixed

People

(Reporter: davidwalsh, Assigned: stepan)

Details

Attachments

(1 file)

Bug 1562724 - Fix "execute getter" button in Debugger Preview popup. r=nchevobbe.
47 bytes, text/x-phabricator-request
Details | Review

STR:

  1. Go to https://codepen.io/anon/pen/JQLORP
  2. Click “increment” (Pauses)
  3. Hover over “this”
  4. Click the “>>” next to “$listeners”

Expected:

The arrows go away and you get a value

Actual:

Nothing happens

The “>>” does work properly in the scopes pane, however.

I can reproduce this on my machine, thanks for the report David.

Honza

Priority: -- → P3

Hi, is this one still available? I'd like to take it.

Flags: needinfo?(dwalsh)

The 'getter button' doesn't work correctly only on the root level items in the 'Popup' element. Any items on depth 1+ display values correctly.

I added a check if a root item has any corresponding 'evaluation' from the 'getter executing', and if so the root item gets that 'evaluation'.

Assignee: nobody → obdelnik
Status: NEW → ASSIGNED
Flags: needinfo?(dwalsh)
Attachment #9123110 - Attachment description: Bug 1562724 - 'execute getter' not working in Preview r=jlast → Bug 1562724 - Fix "execute getter" button in Debugger Preview popup. r=nchevobbe.
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a4d1d2c08331
Fix "execute getter" button in Debugger Preview popup. r=nchevobbe.

https://hg.mozilla.org/mozilla-central/rev/a4d1d2c08331

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox75: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 75

🎉 thanks a lot Stepan!

Thanks for the help Nicolas!

You need to log in before you can comment on or make changes to this bug.