Closed Bug 1562757 Opened 4 months ago Closed 4 months ago

Use |aFrameAsScrollable|'s pres shell to call ScrollToVisual in ScrollToShowRect in PresShell.cpp

Categories

(Core :: Layout, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: hiro, Assigned: hiro)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Here, we use the given |aPresShell| to call ScrollToVisual but the |aPresShell| is for the document which has the target element of scrollIntoView (or some such), so it's possible that the |aPresShell| is for a nested iframe document.

I am going to try to write a mochitest for this issue.

Assignee: nobody → hikezoe.birchill
Status: NEW → ASSIGNED

We should also check IsRootContentDocumentCrossProcess instead of
IsRootContentDocument there, it will be fixed in bug 1562505.

The test case in this commit is almost copied-n-pasted from
helper_scroll_into_view_bug1516056.html.

It turns out test_group_zoom.html is flaky on TV runs, so the change here will cause some failures on TV runs. But it's originally flaky, see this try run which is based on the current m-c.

Pushed by hikezoe.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1db054865b38
Call ScrollToVisual for the pres shell of the given scrollable frame in ScrollToShowRect. r=botond
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.