1562885 - When the stream limit of SETTINGS_TYPE_MAX_CONCURRENT is reached on a single h2 proxy session we don't open a new session

Status: RESOLVED FIXED

(Core :: Networking: Proxy, defect, P3)

Comment 1

[Andrew Sun (prev. [e-mail])]

Related to https://bugzilla.mozilla.org/show_bug.cgi?id=1556005 ?

Comment 2

[Honza Bambas (:mayhemer)]

(In reply to Andrew Sun from comment #1)

Related to https://bugzilla.mozilla.org/show_bug.cgi?id=1556005 ?

Yes and no. I think there is more than one bug around our h2 proxying code..

Comment 3

[Liz Henry (:lizzard)]

Changing to corp confidential temporarily (till after Sept 10) on Tony and elan's request.

Comment 4

[BMO Automation]

Moving bug to Core/Networking: Proxy.

Comment 5

[BMO Automation]

Moving bug to Core/Networking: Proxy

Comment 6

[Valentin Gosu [:valentin] {{ PTO 3 July - 3 August }}]

This should be easily testable:
Create a NodeHttp2ProxyServer, set a low maxConcurrentStreams, make more than maxConcurrentStreams requests to a server that only responds after 1 second.
The test should verify how many proxy connections are made.

Comment 7

[Kershaw Chang [:kershaw]]

I think this bug should be already fixed.
The code to check SETTINGS_TYPE_MAX_CONCURRENT value is here and we should respect this settings.
I'll add a test for this.

Comment 8

[Kershaw Chang [:kershaw]]

Attachment: (secure)

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/63fd337e9994
https://hg.mozilla.org/integration/autoland/rev/635b829771eb
Ensure new HTTP/2 proxy session is opened when concurrent stream limit is hit, r=necko-reviewers,jesup

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/635b829771eb