Closed
Bug 1562956
Opened 5 years ago
Closed 5 years ago
Eslint: allow dash in tag name in xul documents
Categories
(Developer Infrastructure :: Lint and Formatting, task)
Developer Infrastructure
Lint and Formatting
Tracking
(firefox69 fixed)
RESOLVED
FIXED
mozilla69
Tracking | Status | |
---|---|---|
firefox69 | --- | fixed |
People
(Reporter: bgrins, Assigned: bgrins)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
I noticed a permaorange on eslint when trying to build a custom element with a dash in the name: https://phabricator.services.mozilla.com/D35446#1054233. Sounds like there may be an easy solution:
This is probably quite easy to fix. xul.js uses the tag name to form part of the function name that it passes to ESLint. That isn't critical, so we can change - to _ or something in the name, or just strip it completely.
We could do the replace on the node.local value in this section: https://searchfox.org/mozilla-central/rev/7e158713cf5a8514fa8161dd4a239737b05da64d/tools/lint/eslint/eslint-plugin-mozilla/lib/processors/xul.js#142-149
Assignee | ||
Comment 1•5 years ago
|
||
Pushed by bgrinstead@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8b928b1224c7 eslint: allow dash in tag names in xul documents;r=Standard8
Comment 3•5 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox69:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Updated•5 years ago
|
Assignee: nobody → bgrinstead
Pushed by geoff@darktrojan.net: https://hg.mozilla.org/comm-central/rev/ee2fd60f9f9f Port bug 1562956 - Re-enable linting of three XUL files which previously broke the linter; rs=me DONTBUILD
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•