1563024 - Add the ability to launch a search in private browsing mode from the context menu

Status: VERIFIED FIXED

(Firefox :: Search, task, P1)

Description

[Mark Banner (:standard8)]

As part of the private browsing search engine changes, we want to add a new entry into the context mode (for non-private) to be able to launch a search in private browsing mode directly. This should also use the private browsing search engine.

Comment 1

[Mark Banner (:standard8)]

Note: enable/disable display per the pref added in bug 1562922.

Comment 2

[Mike de Boer [:mikedeboer]]

Attachment: Bug 1563024 - Add a context menu item for the in-content popup to allow to perform a search in a new private window, using a private browsing mode default search engine. r?jaws!,Standard8,mak

Comment 3

[Mike de Boer [:mikedeboer]]

Attachment: Bug 1563024 - Adapt unit tests to include coverage for the new Search in Private Window context menu option. r?Standard8,mak

Depends on D48672

Comment 4

[Mike de Boer [:mikedeboer]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ec8329d2172b1ebb186c735de71978738c08c51b

Comment 5

[Mike de Boer [:mikedeboer]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=41d1f50c5eea17d810149597866aa9f8aedc15b5

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/30c22dd7539e
Add a context menu item for the in-content popup to allow to perform a search in a new private window, using a private browsing mode default search engine. r=jaws,mak
https://hg.mozilla.org/integration/autoland/rev/cbc66b7170a6
Adapt unit tests to include coverage for the new Search in Private Window context menu option. r=mak

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/30c22dd7539e
https://hg.mozilla.org/mozilla-central/rev/cbc66b7170a6

Comment 8

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Hello! Reproduced the issue with Firefox 69.0a1 (20190702214807) in Windows 10x64.
The issue is verified fixed with Firefox 71.0b9(20191111170815) on Windows 10x64, macOS 10.14 and Ubuntu 18.04. A new context menu option is displayed "Search in a Private Window" while having browser.search.separatePrivateDefault.ui.enabled pref on true.