1563065 - mozilla::Result can't carry MOZ_NON_PARAM success values

Status: RESOLVED FIXED

(Core :: MFBT, defect)

Description

[Jim Blandy :jimb]

mozilla::Result cannot carry a MOZ_NON_PARAM type as its success type, because the constructor for ResultImplementation passes the success value by value, which is what MOZ_NON_PARAM forbids.

Changing the constructors of the various ResultImplementation specializations and the Result front end to pass the value by const reference allows MOZ_NON_PARAM success types to work.

Comment 1

[Jim Blandy :jimb]

Attachment: Bug 1563065: Use const& in mozilla::Result constructors. r?froydnj

Change the ResultImplementation and Result constructors to accept success
values by const reference. This makes it possible for Result to carry
MOZ_NON_PARAM types as success values.

Comment 2

[Jim Blandy :jimb]

Try push, build only: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4c31bd418998d27e937768801b1304094edb55f1

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/921eab31ab8e
Use const& in mozilla::Result constructors. r=froydnj

Comment 4

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/921eab31ab8e