1563310 - Update ProfilerGetSymbols.jsm to pick up PR #2

Status: RESOLVED FIXED

(Core :: Gecko Profiler, task, P3)

Description

[Markus Stange [:mstange]]

In the profiler-get-symbols repository, Ted recently landed a PR: https://github.com/mstange/profiler-get-symbols/pull/2

I'll be using this bug to update ProfilerGetSymbols.jsm to pick up the new wasm module that was built from the updated code.

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1563310 - Update profiler-get-symbols WASM module and update JS code for the updated binding API. r?kmag

The repo has seen three notable changes since last time:

• The pdb changes from PR #2, which don't really affect any outward behavior.
• I updated the version of wasm-bindgen.
• I created a WasmMemBuffer abstraction which lets us avoid the buffer copy
  without relying on wasm-bindgen implementation details. This is possible due
  to the new Uint8Array::view API that wasm-bindgen shipped in April.

The last part is what allowed me to simplify the code in ProfilerGetSymbols-worker.js.
Those changes are the only part that's worth reviewing.

The changes in profiler_get_symbols.js are not worth reviewing; they're
autogenerated by wasm-bindgen. The new version of wasm-bindgen generates
slightly different JS code, and the addition of the WasmMemBuffer struct also
caused some of that JS code to change.

Comment 2

[Christina Cheung]

Attachment: Bug 1563310: Refactor get_compact_symbol_table in profiler_get_symbols to adjust to return result param

Comment 3

[Phabricator Automation]

Comment on attachment 9079450 [details]
Bug 1563310: Refactor get_compact_symbol_table in profiler_get_symbols to adjust to return result param

Revision D38718 was moved to bug 1567590. Setting attachment 9079450 [details] to obsolete.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e5a6e4d16569
Update profiler-get-symbols WASM module and update JS code for the updated binding API. r=julienw

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/e5a6e4d16569

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.