Closed Bug 1563311 Opened 7 months ago Closed 7 months ago

Remove MOZ_BUILD_WEBRENDER and MOZ_ENABLE_WEBRENDER

Categories

(Core :: Graphics: WebRender, task)

task
Not set

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: kats, Assigned: kats)

Details

Attachments

(3 files)

The MOZ_BUILD_WEBRENDER compile-time define still exists to build firefox without WR. But now that WR is shipping and here to stay, we should get rid of this define and just always assume it's being built.

MOZ_ENABLE_WEBRENDER can go too. It was only ever set if somebody did ac_add_options --enable-webrender and would just set gfx.webrender.enabled to true in the build. I don't think there's much value to that anymore.

https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=178ac91ca92b916e776409f0fefb47f671eda5d4

Summary: Remove MOZ_BUILD_WEBRENDER → Remove MOZ_BUILD_WEBRENDER and MOZ_ENABLE_WEBRENDER

This removes support for building Firefox/Gecko without WebRender.

This assumes MOZ_ENABLE_WEBRENDER is always false. It effectively
removes support for enabling WebRender via ac_add_options --enable-webrender
in the mozconfig. Other mechanisms for enabling WebRender remain
untouched.

Depends on D36819

This drops the MOZ_BUILD_WEBRENDER and MOZ_ENABLE_WEBRENDER flags
which are unused after the preceding two patches.

Depends on D36820

Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5c6c8e59e12c
Remove uses of MOZ_BUILD_WEBRENDER. r=aosmond
https://hg.mozilla.org/integration/autoland/rev/6f9349256d7c
Remove uses of MOZ_ENABLE_WEBRENDER. r=aosmond
https://hg.mozilla.org/integration/autoland/rev/6ee8e7cdb4a5
Remove the --enable-webrender ac_options. r=froydnj
You need to log in before you can comment on or make changes to this bug.