1563318 - Return inline callstacks, filenames and line numbers from ProfilerGetSymbols API, if debug information is present

Status: RESOLVED FIXED

(Core :: Gecko Profiler, enhancement, P3)

Description

[Markus Stange [:mstange]]

Once we have a new ProfilerGetSymbols API that lets us request information for a given set of addresses (bug 1563316), we can start to return a richer set of data for each address. Instead of just returning the closest symbol name and the address's offset from the symbol, if we have access to the binary's debug information, we can also return the following:

• The function names of any functions that were inlined by the compiler at this address (the "inline stack")
• The filename where each of these functions lives in the source code
• The line number of the code line that produced this instruction, for each inline stack frame

Once we have this information, we can display much richer information in the profiler frontend, e.g. issue 2121 is about inline stacks in the call tree.

Comment 1

[Christina Cheung]

Attachment: Bug 1563318 - Add symbolication API for reading local binary files.

Comment 2

[Markus Stange [:mstange]]

This is now implemented; the pieces landed in bug 1615066 and in bug 1563316.

Thank you Christina for creating the initial proof of concept!