1563331 - Reftest regression from tab conversion

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect, P2)

Description

[Brendan Dahl [:bdahl]]

Attachment: chrome.patch

Over in bug 1557371 I'm converting all XUL reftests to be loaded with system privilege. In the process of doing that, it will fix a number of broken reftests. One of those broken tests that will be fixed is 272646-1.xul. However, in the last few days, bug 1555060 regressed the fixed test.

Str:

1. apply patch
2. run ./mach reftest layout/reftests/bugs/reftest.list

Comment 1

[Brendan Dahl [:bdahl]]

Attachment: file_uri_broken.png

Comment 2

[Brendan Dahl [:bdahl]]

Attachment: chrome_uri_fixed.png

Comment 3

[Brendan Dahl [:bdahl]]

Attachment: new_tab_ce_with_chrome_uri.png

Comment 4

[Brendan Dahl [:bdahl]]

Comment on attachment 9075756 [details] [diff] [review]
chrome.patch

Now that the changes to reftests have landed the patch is no longer needed. Just run the reftest chrome://reftest/content/bugs/272646-1.xul

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:aswan, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 6

[Andrew Swan [:aswan]]

Attachment: Bug 1563331 Fix obsolete use of <tabs> r=bdahl

After bug 1555060, <tabs> elements should not use dom accessors to get
to the <tab> elements inside a <tabs>. This test was using lastChild,
this patch brings it up to date.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/521e6dab1fd4
Fix obsolete use of <tabs> r=bdahl

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/521e6dab1fd4