Closed Bug 1563331 Opened 2 years ago Closed 2 years ago

Reftest regression from tab conversion

Categories

(Toolkit :: XUL Widgets, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox68 --- unaffected
firefox69 --- unaffected
firefox70 --- fixed

People

(Reporter: bdahl, Assigned: aswan)

References

(Regression)

Details

(Keywords: regression)

Attachments

(4 files, 1 obsolete file)

Attached patch chrome.patch (obsolete) — Splinter Review

Over in bug 1557371 I'm converting all XUL reftests to be loaded with system privilege. In the process of doing that, it will fix a number of broken reftests. One of those broken tests that will be fixed is 272646-1.xul. However, in the last few days, bug 1555060 regressed the fixed test.

Str:

  1. apply patch
  2. run ./mach reftest layout/reftests/bugs/reftest.list
Component: XBL → XUL Widgets
Product: Core → Toolkit
Comment on attachment 9075756 [details] [diff] [review]
chrome.patch

Now that the changes to reftests have landed the patch is no longer needed. Just run the reftest chrome://reftest/content/bugs/272646-1.xul
Attachment #9075756 - Attachment is obsolete: true

The priority flag is not set for this bug.
:aswan, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(aswan)

After bug 1555060, <tabs> elements should not use dom accessors to get
to the <tab> elements inside a <tabs>. This test was using lastChild,
this patch brings it up to date.

Assignee: nobody → aswan
Flags: needinfo?(aswan)
Priority: -- → P2
Pushed by aswan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/521e6dab1fd4
Fix obsolete use of <tabs> r=bdahl
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
Whiteboard: [checkin-needed-beta]
You need to log in before you can comment on or make changes to this bug.