1563343 - No calls to GeckoSession.NavigationDelegate#onLoadError when an ERROR_UNKNOWN_PROTOCOL occurs

Status: RESOLVED FIXED

(GeckoView :: General, defect, P1)

Description

[Arturo Mejia [:amejia]]

We are not getting any calls to GeckoSession.NavigationDelegate#onLoadError when an ERROR_UNKNOWN_PROTOCOL occurs.

You can reproduce this issue by trying to navigate to htt://invalid using the GeckoView Sample app. This should be shown an error page, but nothing is shown.

Related Fenix issue an Android Components issue.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Yeah, I can reproduce this.

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

We expect the app to handle things like intent:// in onLoadRequest, but if it allows it to go through we should definitely display an error page. It looks like Gecko might be going into the "external app" machinery here which we really don't want.

Comment 3

[Chris Peterson [:cpeterson]]

Needs investigation. This is a bad user experience.

Comment 4

[[ex-Mozilla] Agi Sferro | :agi]

Fennec fixes this by catching the exception thrown by loadURI and sending a LoadError message: https://searchfox.org/mozilla-central/rev/07f7390618692fa4f2a674a96b9b677df3a13450/mobile/android/chrome/content/browser.js#1710-1728

However, I can't seem to find out what Desktop does for this case, it feels like there should be a better way to handle this.

Comment 5

[Chris Peterson [:cpeterson]]

I'm editing a bunch of GeckoView bugs. If you'd like to filter all this bugmail, search and destroy emails containing this UUID:

e88a5094-0fc0-4b7c-b7c5-aef00a11dbc9

Comment 6

[Chris Peterson [:cpeterson]]

Adding this bug to GV's September sprint.

Comment 7

[Chris Peterson [:cpeterson]]

Dylan says he's working on this bug to remove the OS protocol handler code.

Comment 8

[Dylan Roeh (:droeh) (he/him)]

Attachment: Bug 1563343 - Do not search for OS protocol handlers in GV; just let Gecko return ERROR_UNKNOWN_PROTOCOL. r=#geckoview-reviewers!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/16d04cad3cf9
Do not search for OS protocol handlers in GV; just let Gecko return ERROR_UNKNOWN_PROTOCOL. r=snorp

Comment 10

[Alexandru Michis [:malexandru]]

Backed out changeset 16d04cad3cf9 for causing failures in test_handlerService_store and same-origin.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/329fde2dbe94b203fe93bb0ba4c87f78980d3f3f

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&tochange=329fde2dbe94b203fe93bb0ba4c87f78980d3f3f&fromchange=16d04cad3cf99f30a8abb7892a280847d32c1822&selectedJob=268874197

Failure logs:

• https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=268866417&repo=autoland&lineNumber=4080
• https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=268866402&repo=autoland&lineNumber=5415
• https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=268867832&repo=autoland&lineNumber=2126

Comment 11

[Chris Peterson [:cpeterson]]

Tracking for GV's October sprint. Dylan says he'll fix the geo test failures soon and reland.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/70cd4ff8583c
Do not search for OS protocol handlers in GV; just let Gecko return ERROR_UNKNOWN_PROTOCOL. r=snorp,geckoview-reviewers,esawin

Comment 13

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/70cd4ff8583c