Closed
Bug 1563370
Opened 5 years ago
Closed 5 years ago
Eliminate GetPrevInFlowVirtual() and GetNextInFlowVirtual()
Categories
(Core :: Layout, task, P3)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla69
Tracking | Status | |
---|---|---|
firefox69 | --- | fixed |
People
(Reporter: TYLin, Assigned: TYLin)
Details
Attachments
(1 file)
In bug 299065 comment 31, nsIFrame::GetPrevInFlowVirtual
and nsIFrame::GetNextInFlowVirtual
were introduced to avoid virtual function calls to nsIFrame::GetPrevInFlow
and nsIFrame::GetNextInFlow
if the callers hold a pointer of derived classes like nsSplittableFrame
or nsTextFrame
.
Nowadays, C++ already has the final
keyword. I see no particular reason to continue to use this workaround.
Assignee | ||
Comment 1•5 years ago
|
||
Pushed by aethanyc@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/8afe177a67a8
Eliminate GetPrevInFlowVirtual() and GetNextInFlowVirtual(). r=dholbert
Comment 3•5 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox69:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in
before you can comment on or make changes to this bug.
Description
•