1563473 - [accessibility] The skip to section links icon has no discernible text

Status: RESOLVED WONTFIX

(developer.mozilla.org Graveyard :: General, defect, P2)

Description

[Schalk Neethling [:espressive]]

The skip to section links next to heading on wiki pages receive focus, but have no accessible name, and have aria hidden set to true. <a href="#Basics" class="sectionLink"> 🔗</a>

1. Do not set aria-hidden to true
2. Add a label
3. Use a standard SVG icon from Dinocons

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/kuma/pull/5539

Comment 2

[David Flanagan [:djf]]

The PR has already been merged, but I left a comment on it anyway. The recursive use of React's render() function in that PR scares me. Perhaps irrationally. But since we're using an effect funtion to edit the DOM which was injected with dangerouslySetInnerHTML, I'd suggest that the icon should be handled without any React code. I suggest just define the icon as a static string in the .js file and use innerHTML (possibly with cloneNode() as an optimization) to get the icon inside the link.

Comment 3

[BMO Automation]

MDN Web Docs' bug reporting has now moved to GitHub. From now on, please file content bugs at https://github.com/mdn/sprints/issues/ and platform bugs at https://github.com/mdn/kuma/issues/.