1563565 - Stub installer gets stuck at ~60% on ARM

Status: VERIFIED FIXED

(Firefox :: Installer, defect, P1)

Description

[Gyula Palko[:gpalko]]

[Environment:]
69.0a1 Nightly Win10/aarch64

[Steps:]
Download and run the Installer from https://archive.mozilla.org/pub/firefox/nightly/latest-mozilla-central/

[Actual Result:]
The installer gets stuck at ~60%, Nightly is not installed

[Expected Result:]
FF Nightly should be successfully installed

[Note]
Tested on Lenovo Yoga

Comment 1

[Molly Howell (she/her) (mostly inactive)]

Easily reproducible for me; I'll investigate.

This could be a regression from bug 1553537, but I'm not sure yet.

Comment 2

[Molly Howell (she/her) (mostly inactive)]

Confirmed this is definitely bug 1553537. No idea yet why that change would cause this, and only on ARM64.

[Tracking Requested - why for this release]:
This bug makes the stub installer effectively useless on ARM64 Windows.

Comment 3

[Molly Howell (she/her) (mostly inactive)]

I found the problem. As a basic sanity check, the stub installer compares the size of the full installer that it downloads against an expected minimum and maximum. If that fails we retry the download. The ARM64 installer has exceeded the maximum (which is 70 MB) primarily because of bug 1529194 and its bundling of most of an x86 build inside of the ARM64 build, so we're just retrying forever.

I do not understand why bug 1553537 caused this check to start triggering when it was not before. My guess is that some timing condition was causing the file size to not be reported properly, since I can occasionally get the install to succeed even with this bug in place. Given the above, I think the proper fix is really just to raise the maximum download size value. With the current state of the code everything seems to be working as expected, so I think that's the only necessary change.

Comment 4

[Molly Howell (she/her) (mostly inactive)]

Attachment: Bug 1563565 - Raise the stub installer maximum download size limit. r=agashlin

The installer for aarch64 Windows has exceeded the current limit. This new one
(150 MB) should allow enough breathing room while still being reasonable.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a652f09ed1cf
Raise the stub installer maximum download size limit. r=agashlin

Comment 6

[Molly Howell (she/her) (mostly inactive)]

Comment on attachment 9078543 [details]
Bug 1563565 - Raise the stub installer maximum download size limit. r=agashlin

Beta/Release Uplift Approval Request

• User impact if declined: The stub installer is effectively useless on ARM64 Windows machines.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See comment 0.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch simply raises the installer size limit and doesn't include any other changes.
• String changes made/needed:

Comment 7

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/a652f09ed1cf

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9078543 [details]
Bug 1563565 - Raise the stub installer maximum download size limit. r=agashlin

Stub installer fix needed for ARM64 builds. Approved for 69.0b6.

Comment 9

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/releases/mozilla-beta/rev/40cbf62e4643

Comment 10

[Alin Ilea, Desktop Test Engineering]

Verified - fixed on latest Nightly 70.0a1 (2019-07-18) on Lenovo Yoga Win10/aarch64.

Comment 11

[Alin Ilea, Desktop Test Engineering]

Verified - fixed on latest Beta 69.0b6 on Lenovo Yoga Win10/aarch64.