1563624 - Reject async IPC promises if `Resolver` argument is dropped

Status: RESOLVED FIXED

(Core :: IPC, enhancement, P3)

Description

[Nika Layzell [:nika] (ni? for response)]

Currently, if the Resolver argument to an async IPC callback is dropped on the floor, the promise on the other side is never resolved until the actor in question is destroyed. This means it's possible to forget to call the resolver, not hold a reference to it, and it will never be called.

We could detect if the last reference to the resolver has been dropped, and automatically reject the promise now that it will never be fulfilled.

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1563624 - Part 1: Add a weak reference variant of ActorLifecycleProxy for IPDL internal use,

Comment 2

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1563624 - Part 2: Automatically reject async IPC responses when the resolver is dropped,

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/90f08512c313
Part 1: Add a weak reference variant of ActorLifecycleProxy for IPDL internal use, r=mccr8
https://hg.mozilla.org/integration/autoland/rev/66109fd063dd
Part 2: Automatically reject async IPC responses when the resolver is dropped, r=mccr8

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/90f08512c313
https://hg.mozilla.org/mozilla-central/rev/66109fd063dd