Closed
Bug 1563685
Opened 5 years ago
Closed 5 years ago
Rename JSM or exported class in order to the class match the file name
Categories
(Remote Protocol :: Agent, enhancement)
Remote Protocol
Agent
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ochameau, Assigned: ochameau)
References
Details
Attachments
(2 files)
A few classes like WebSocketDebuggerTransport are having a different name than their file.
For the sake of clarity, we should align class names with the file they are implemented into.
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → poirot.alex
Assignee | ||
Comment 1•5 years ago
|
||
Assignee | ||
Comment 2•5 years ago
|
||
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6525d810b0b0
Rename WebSocket.jsm and drop unused accept method. r=remote-protocol-reviewers,jdescottes,ato
https://hg.mozilla.org/integration/autoland/rev/10109cbe9641
Rename WebSocketDebuggerTransport class to match its JSM file name. r=remote-protocol-reviewers,jdescottes,ato
Backout by shindli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2a5b1743e58a
Backed out 2 changesets for causing bc perma failures in browser/base/content/test/static/browser_all_files_referenced.js CLOSED TREE
Comment 5•5 years ago
|
||
Backed out 2 changesets (Bug 1563685) for causing bc perma failures in browser/base/content/test/static/browser_all_files_referenced.js CLOSED TREE
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=255282712&repo=autoland&lineNumber=2819
Flags: needinfo?(poirot.alex)
Assignee | ||
Updated•5 years ago
|
Flags: needinfo?(poirot.alex)
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/95f85f3b71bd
Rename WebSocket.jsm and drop unused accept method. r=remote-protocol-reviewers,jdescottes,ato
https://hg.mozilla.org/integration/autoland/rev/404680ad41e4
Rename WebSocketDebuggerTransport class to match its JSM file name. r=remote-protocol-reviewers,jdescottes,ato
Comment 7•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/95f85f3b71bd
https://hg.mozilla.org/mozilla-central/rev/404680ad41e4
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•