1563687 - Unify the various clean/destroy/disconnect methods

Status: RESOLVED FIXED

(Remote Protocol :: Agent, enhancement)

Description

[Alexandre Poirot [:ochameau]]

One convention stands out of the current code: most of the cleanup/destruction code operates from a method called destructor, which cleanly matches constructor method used by ES6 classes.

At least one component, ContentProcessSession names it destroy. We should rename it.

Then, we use the word disconnect for something that looks more like a destruction than a disconnection. In the case of Targets, the usage of connect and disconnect is misleading as when these methods are called (connect/disconnect), there is no connection being made. Instead it is about a target being just created and to be registered, and a target being destroyed and to be unregistered and forget about. That looks more like a contructor/destructor pattern.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1563687 - Renamed ContentProcessSession.destroy to destructor in order to match this project's conventions.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1563687 - Rename Targets.disconnect to destructor to better match project's conventions.

Connect and disconnect in misleading here as a target aren't connected/disconnected,
but instead, being unregistered and destroyed. The fact that they are "disconnected"
is a side effect of this destruction. Also note that a Target is never "connected",
it is only a Connection and its related sessions which really are connected to a remote client.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc54f88b32e0
Renamed ContentProcessSession.destroy to destructor in order to match this project's conventions. r=remote-protocol-reviewers,jdescottes

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/fc54f88b32e0

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f5a12c2479a1
Rename Targets.disconnect to destructor to better match project's conventions. r=remote-protocol-reviewers,jdescottes,ato

Comment 6

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/f5a12c2479a1

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Alexandre, is something left here for landing or can the bug been closed now?

Comment 8

[Alexandre Poirot [:ochameau]]

It can be closed, I forgot to remove the leave-open when landing the second last part.