1563690 - Hold a list of Connection instead of Sessions from Target

Status: RESOLVED FIXED

(Remote Protocol :: Agent, enhancement)

Description

[Alexandre Poirot [:ochameau]]

As connection already holds a list of Sessions, it is a bit misleading to also store a list of Session form Target, whereas at the end we only care about the Connection from Target.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1563690 - Make Target class save a list of Connection rather than Session.

Connection already saves the list of Session, so it is more natural
to save it only once there and instead directly close the connections
from Target. Each connection is going to cleanup all related sessions.

I also stop automatically registering the session to the connection from Session constructor,
it felt not explicit enough.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ab61d517c2e
Make Target class save a list of Connection rather than Session. r=remote-protocol-reviewers,jdescottes

Comment 3

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/7ab61d517c2e