1563741 - New tab content should not be scrollable when about:welcome is visible

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Kate Hudson :k88hudson]

Attachment: Actual

Right now on about:welcome (with the new modal experience enabled), the page is scrollable past the actual modal content; it should only be scrollable to the bottom of the modal content (until the modal is dismissed)

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5162

Comment 2

[Jeane Carlos]

In the PR I kept the page fixed and the modal in the center. When there is a low screen resolution or the user zooms in, then the overflow occurs in the modal itself not on the page (making the modal always centered). Alternatively, we could have the modal cut off and the user has to scroll down (similar to how it is currently).

https://drive.google.com/open?id=1AtQF14SAYbGwUwwP3nBe1os5kd3yn6JI

Comment 3

[Aaron Benson]

This looks good! The page scrolling vs. modal content scrolling is almost imperceptible so it WFM. Are we confident this change gets the modal fully in the content view for our common smaller screen resolution?

Comment 4

[Jeane Carlos]

Yes at 1280 x 800 the content is still largely fully in view. Only at 1024 x 640 (lowest option on mac) does the scroll appear.

Comment 5

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/16d1399f602c

Comment 6

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (70.0a1 Build ID - 20190721215935) installed, on Windows 10 x64, Arch Linux and Mac 10.14.5. Now, the page is no longer scrollable past the modal.