Open Bug 1563757 Opened 6 years ago Updated 3 years ago

Track Changes: Ensure ChangesActor/ChangesFront always fires change events

Categories

(DevTools :: Inspector: Changes, task, P2)

task

Tracking

(Not tracked)

People

(Reporter: rcaliman, Unassigned)

References

(Blocks 1 open bug)

Details

The ChangesActor has an optimization to avoid firing events on changes unless there's evidence of a consumer for those events.
Until a call to ChangesActor.allChanges() is made, no events will be fired that a client can listen to.

The intention for this optimization was to avoid needless event traffic unless the Changes panel was in view (it calls allChanges() once opened).

However, other interested consumers of change events have sprung up and this subtle optimization caused trouble for them with inconsistent firing of events.

Therefore, we should remove this optimization which trips up other developers and always fire change events regardless of any previous method calls to the ChangesActror.

Summary: Track Changes: Ensure actor always fires change events → Track Changes: Ensure ChangesActor/ChangesFront always fires change events

If moving to a Changes ResouceWatcher-based approach, the singular ChangesActor becomes obsolete.

Assignee: rcaliman → nobody
Status: ASSIGNED → NEW
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.