1563832 - Break up PerformAsyncLaunch

Status: RESOLVED FIXED

(Core :: IPC, task)

Description

[Bobby Holley (:bholley)]

PerformAsyncLaunch is an enormous pile of nested #ifdefs. I've refactored it into a per-platform inheritance hierarchy with method overrides, which makes it much easier to work with.

This depends on the refactoring in bug 1562763, and facilitates the asynchronous conversion in bug 1562762.

Comment 1

[Bobby Holley (:bholley)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=eb2f24c4203e60c8387b37dd810dc9c9c1f4d9a4

Comment 2

[Bobby Holley (:bholley)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d61807862329d2c4b71e7688e41ae8a9987b3bf2

Comment 3

[Bobby Holley (:bholley)]

Attachment: Bug 1563832 - Create an inheritance hierarchy for the platform-specific bits of process launching.

Comment 4

[Bobby Holley (:bholley)]

Attachment: Bug 1563832 - Move a few things into BaseProcessLauncher.

I'm not convinced the current comment about being race-free is accurate
in context of the launcher pool. It probably is correct under this
patch, because ProcessLaunchers should only be constructed on a single
thread, but it's easy enough just to make it atomic.

Hopefully moving the timestamp doesn't perturb telemetry too much.

Comment 5

[Bobby Holley (:bholley)]

Attachment: Bug 1563832 - Decompose PerformAsyncLaunch into the platform hierarchy.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79629d87282a
Create an inheritance hierarchy for the platform-specific bits of process launching. r=jld
https://hg.mozilla.org/integration/autoland/rev/3f03d5f1ebfb
Move a few things into BaseProcessLauncher. r=jld
https://hg.mozilla.org/integration/autoland/rev/fd887713ac62
Decompose PerformAsyncLaunch into the platform hierarchy. r=jld

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/79629d87282a
https://hg.mozilla.org/mozilla-central/rev/3f03d5f1ebfb
https://hg.mozilla.org/mozilla-central/rev/fd887713ac62