1564071 - Element with position: sticky inside element with a filter scrolls with content

Status: VERIFIED FIXED

(Core :: Panning and Zooming, defect, P3)

Description

[Michael Müller]

Attachment: sticky-filter-bug.html

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:67.0) Gecko/20100101 Firefox/67.0

Steps to reproduce:

1. Open attached HTML file (which has a position: sticky element inside a filter: brightness(1) element).
2. Scroll.

Actual results:

The sticky element scrolls with the content, and only jumps back to the bottom when you resize the window.

Expected results:

The sticky element should always be at the bottom, and not scroll with the content.

Comment 1

[Alice0775 White]

I can reproduce the issue on Nightlu69.0a1 Windows10 if disable WebRender

Comment 2

[Alice0775 White]

Disabled APZ fixes the issue

Comment 3

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=69d79f3e6649eddd011b7985e163f1ff1bb41412&tochange=3e9a803d69edcf799fc979690098f5a176584eac

Regressed by: Bug 1192910

Comment 4

[Botond Ballo [:botond]]

I expect this has the same root cause as bug 1404218. See also bug 1418923 for relevant discussion.

Note that this bug does not affect WebRender; if enabling that is an option for you, that's the most effective workaround.

Comment 5

[Botond Ballo [:botond]]

It also occurs to me that we mitigated the issue underlying bug 1404218 significantly in bug 1300864, but the mitigation does not apply to sticky elements. We may be able to extend the mitigation to apply to sticky elements as well.

Comment 6

[Botond Ballo [:botond]]

Attachment: Bug 1564071 - Disable paint skipping for scroll frames that contain a sticky element inside a CSS filter. r=mstange

Comment 7

[Botond Ballo [:botond]]

Let's use this bug to track extending the mitigation to sticky elements.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/67d64b7bb76b
Disable paint skipping for scroll frames that contain a sticky element inside a CSS filter. r=mstange

Comment 9

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/67d64b7bb76b

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Is this something we should consider for Beta uplift?

Comment 11

[Botond Ballo [:botond]]

I think we should.

Comment 12

[Botond Ballo [:botond]]

Comment on attachment 9077165 [details]
Bug 1564071 - Disable paint skipping for scroll frames that contain a sticky element inside a CSS filter. r=mstange

Beta/Release Uplift Approval Request

• User impact if declined: On some page structures containing a position:sticky element inside a CSS filter, scrolling can result in the position:sticky element moving even when it's supposed to stay fixed, and the incorrect rendering can persist for an arbitrarily long time, usually until further user interaction like a click.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Very simple patch, only affects an optimization, and very specific page structures.
• String changes made/needed:

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9077165 [details]
Bug 1564071 - Disable paint skipping for scroll frames that contain a sticky element inside a CSS filter. r=mstange

Disables an optimization which can cause incorrect rendering of position:sticky elements in some cases. Approved for 69.0b10.

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/eb98783c379c

Comment 15

[Emil Ghitta, QA [:emilghitta]]

I have managed to reproduce this issue using Firefox 69.0b3 (BuildId:20190708182549) on Windows 10 64bit.

This issue is verified fixed using Firefox 70.0a1 (BuildId:20190805220030) and Firefox 69.0b10 (BuildId:20190801185445) on Windows 10 64bit, macOS 10.13.6 and Ubuntu 18.04 64bit.

Comment 16

[Edmar Gomes]

Doesn't work for me.

I use 81.0 version for Ubuntu

I comment here https://bugzilla.mozilla.org/show_bug.cgi?id=1444198

Comment 17

[Botond Ballo [:botond]]

(In reply to Edmar Gomes from comment #16)

Doesn't work for me.

I use 81.0 version for Ubuntu

I comment here https://bugzilla.mozilla.org/show_bug.cgi?id=1444198

The symptoms are similar, but this bug and bug 1444198 are unrelated. This bug is about position: sticky, while bug 1444198 is about position: fixed and position: absolute. (Also, this bug is about an implementation issue that has been fixed, while bug 1444198 is about a behaviour that was recently clarified in the spec, and but is not yet fixed.)