1564082 - The app crash after reopening the recent closed tabs

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect, P1)

Description

[Stefan Deiac]

Attachment: logcat.txt

Environment:
Devices:

• Xiaomi Mi 8 Lite (Android 9);
• Samsung Galaxy Tab 3 (Android 8).

Build: RC 68.0 build 3;

Prerequisites:
You have some pages recently closed(+5 pages);

Steps to reproduce:

1. Go to History -> Recently closed tab;
2. Tap on "Restore all" button;

Expected result:
All tabs from the list are restored without any problem.

Actual result:
The App crash after trying to Restore all tabs

Notes:

• Reproducible 1/3 times;
• Reproducible on Nightly 69.0a1 (2019-07-07) and Beta 68.0b14

Comment 1

[Marcia Knous [:marcia]]

Adjusting crash signature so it gets picked up in crash stats.

Comment 2

[Andrei Lazar]

Attachment: Bug 1564082 The app crash after reopening the recent closed tabs r=petru

The cursor was trying to move to first record after it was closed which lead into
IllegalStateException.
In order to avoid this exception, we should simply check if the cursor was already
closed before trying to move to the first record.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/723a54f6eb3b
The app crash after reopening the recent closed tabs r=petru

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/723a54f6eb3b

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta and ESR68 approval when you get a chance.

Comment 6

[Andrei Lazar]

Comment on attachment 9078166 [details]
Bug 1564082 The app crash after reopening the recent closed tabs r=petru

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is a critical bug, it reproduces 100% of time.
• User impact if declined: The users will encounter a crash every time they try to open all recent tabs from History.
• Fix Landed on Version:
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This change is not risky because it simply enforces a pattern (to always check if a cursor is not already closed before trying to do anything with it) that is being pushed by Google.
• String or UUID changes made by this patch:

Comment 7

[Stefan Deiac]

Hello, I can confirm that the issue is fixed on Nightly 70.a1 (2019-07-17) using Samsung Galaxy S8 (Android 9) and Samsung Galaxy Tab S3 (Android 8.0).

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9078166 [details]
Bug 1564082 The app crash after reopening the recent closed tabs r=petru

Fixes a frequent Fennec crash. Approved for Beta and 68.1b3. We may want to keep this on the radar for any Fennec 68.0.x point releases as well given the frequency.

Comment 9

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5ae69f624657

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-esr68/rev/8ccf0434f421

Comment 11

[Eliza Balazs]

Hi!
Verified as fixed on Beta 69.0b7 with OnePlus 5T (Android 9), Motorola Nexus 6 (Android 7.1.1).
I will mark this issue as verified on Firefox 69. Thanks!

Comment 12

[Eliza Balazs]

Verified as fixed on ESR 68.1b3 with OnePlus 5T (Android 9), HTC 10 (Android 8.0.0).
I will mark this issue as verified on Firefox esr68. Thanks!