1564188 - Use remote Fluent files for CFR messages

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Comment 1

[Axel Hecht [:Pike]]

Adding bug 1564268 to the dependencies here, to have an actual loader class from Remote Settings.

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5167

Comment 3

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/eba9b9f96abc

Comment 4

[Nan Jiang [:nanj]]

Notes for QA:

This makes CFR use the remote Fluent file (hosted by Remote Settings) for l10n so that we can deliver CFR messages off the Firefox release train.

Steps to test:

• Open Firefox Nightly
• Flip the pref browser.newtabpage.activity-stream.asrouter.devtoolsEnabled to turn on ASRouter devtools
• Open the ASRouter devtools page by clicking the wrench icon on the top right corner of the newtab page
• On the devtools admin page, there is a Messages section, open the dropdown list of Show messages from, and select cfr
• Scroll down until you find the PIN_TAB message, click on the Show button, a blue button called Recommendation should be popped out in the awesome bar
• Click on the Recommendation button, verify all the texts are localized with the current locale on the recommendation panel. For instance, its title should be "Try This: Pin Tab", followed by its body "Get easy access to your most-used sites. ...". Also, at the bottom, there should be two buttons labelled as "Not Now" and "Pin This Tab"
• Next, let's make sure those texts were localized by the remote Fluent file. This could be done by checking the existence of the file, which should be located in ${localProfileDir}/settings/main/ms-language-packs/, and its name is asrouter.ftl. You can find ${localProfileDir} in about:profiles from the "local directory" entry

We can test the same with another locale, such as de, fr, es, etc. Anyone should be sufficient, there is no need to test all of them.

Comment 5

[Andreea Cupsa [:acupsa], Experiments QA]

Thanks Nan for all the help provided.
I have verified this issue with the steps provided in Comment 4 on Latest Firefox Nightly 71.0a1 IT, DE and FR locales (ID build:20190916155843) on Windows 10 x64, Mac 10.14.5 and Arch Linux 4.16.6 x64.
The Recommendation button is localized according to the locale, and the asrouter.ftl file is displayed in the ${localProfileDir}/settings/main/ms-language-packs/ folder.