1564267 - Formatted console logs with larger font-height are cut off by fixed line-height

Status: VERIFIED FIXED

(DevTools :: Console, defect, P2)

Description

[:Harald Kirschner :digitarald]

Attachment: image.png

What were you doing?

1. Open Console
2. Execute console.log("%cIs this visible enough?", "color: cyan; font-size: 6rem;")

What happened?

Text is cut off because of fixed line-height.

What should have happened?

Text shows in correct font-size and height.

Anything else we should know?

Works in 67.

Comment 1

[Florens Verschelde :fvsch]

Regressed by me in https://hg.mozilla.org/mozilla-central/rev/23ab80e6ec5318991ef646bc74515bd4347d0da1#l1.14

Not sure why I moved away from the calc(14 / 11) value, it's usually not a good idea to use fixed values for line-height as shown by this bug.

Comment 2

[Florens Verschelde :fvsch]

Attachment: Bug 1564267 - Fix console line-height for large text; r=nchevobbe

Comment 3

[Florens Verschelde :fvsch]

Affected versions:

• Firefox 69 (beta)
• Firefox 68 (release, ESR)

Haven't confirmed in 68, but the regressing patch landed on 2019-05-14, and Firefox 68 merge date was 2019-05-20.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9f5318689ae7
Fix console line-height for large text; r=nchevobbe

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/9f5318689ae7

Comment 6

[Florens Verschelde :fvsch]

Comment on attachment 9076724 [details]
Bug 1564267 - Fix console line-height for large text; r=nchevobbe

Beta/Release Uplift Approval Request

• User impact if declined: Console messages logged by some JS frameworks or libraries may be unreadable, hurting web developer experience.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): CSS-only patch changing a single value.
• String changes made/needed:

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9076724 [details]
Bug 1564267 - Fix console line-height for large text; r=nchevobbe

Yikes. Approved for 69.0b5 and 68.1esr.

Comment 8

[Razvan Maries]

https://hg.mozilla.org/releases/mozilla-beta/rev/4583a66c4d51

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-esr68/rev/b4d4b2c7e369

Comment 10

[MariaPlachkova :mumuzette]

The issue is no longer reproducible on Firefox 69.0b5 (64-bit), Firefox 70.0a1 (2019-07-18) (64-bit).
Tests were performed under Windows 10 Pro 10.0.17134.

Comment 11

[MariaPlachkova :mumuzette]

The issue is no longer reproducible on Firefox 69.0b5 (64-bit), Firefox 70.0a1 (2019-07-18) (64-bit).
Tests were performed under Kubuntu 18.04.2 LTS bionic (64-bit).
I apologize for the two posts, but wasn't aware that I can't change comments here.

Comment 12

[Mohammad Maruf Rahman]

I have reproduced this bug with Nightly 70.0a1 (2019-07-08) on Windows 7, 64 Bit. The fix of the bug is verified with latest Beta 69.0b9 and latest Nightly.

Build ID 20190730004747
User Agent Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0

Build ID 20190812215403
User Agent Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:70.0) Gecko/20100101 Firefox/70.0