Some JIT prefs cleanup
Categories
(Core :: JavaScript Engine: JIT, task, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Crash Data
Attachments
(2 files)
-
The baseline/Ion/native-regexp prefs should be JitOptions (per-process) instead of per-runtime. This way we only need to set them once in XPConnect instead of for every runtime (I'm pretty sure some runtimes don't respect the browser prefs right now).
-
We should read these prefs only during start-up instead of updating them at runtime. It's too easy to get into an inconsistent state, we bake in certain pref values in JIT code, and it's also very racy with per-process prefs.
|
Assignee | |
Comment 1•5 years ago
|
||
Using process-wide prefs is consistent with the other JIT options and is simpler
to work with (one place to initialize for all runtimes).
|
|
Assignee | |
Comment 2•5 years ago
|
||
Updating these process-wide prefs at runtime is racy, it was easy to get
into a weird state and we bake in some of these values in JIT code.
Depends on D37385
|
||
Updated•5 years ago
|
|
||
Updated•5 years ago
|
|
||
Updated•5 years ago
|
Pushed by jdemooij@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4f267c2d1a7c part 1 - Convert Baseline/Ion/NativeRegExp prefs from ContextOptions to JitOptions. r=nbp,smaug https://hg.mozilla.org/integration/autoland/rev/be4f68034abd part 2 - Load browser JIT prefs only once, during startup. r=nbp
|
|
||
Updated•5 years ago
|
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/4f267c2d1a7c
https://hg.mozilla.org/mozilla-central/rev/be4f68034abd
|
||
Updated•5 years ago
|
Description
•