Closed
Bug 1564505
Opened 6 years ago
Closed 5 years ago
glean-core should have an explicit configuration object, like glean-ac
Categories
(Data Platform and Tools :: Glean: SDK, defect, P1)
Data Platform and Tools
Glean: SDK
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mdroettboom, Assigned: janerik)
Details
(Whiteboard: [telemetry:glean-rs:m6])
Attachments
(1 file)
In adding events support, a new configuration parameter needs to be added.
The current option seems to be to add it as a parameter to the Glean constructor. However, since Rust doesn't have this doesn't scale well, and even if it's an Option
, since Rust doesn't have default parameters, meaning every test would need to be updated to pass this additional parameter.
A better pattern might be to have a Configuration struct that's passed in to the Glean constructor. We could then clone a reasonable default instance of this struct for all tests. Or alternatively, use the Default
decorator to make the Configuration struct easy to construct.
Reporter | ||
Updated•6 years ago
|
Whiteboard: [telemetry:glean-rs:m?] → [telemetry:glean-rs:m6]
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → jrediger
Priority: P3 → P1
Assignee | ||
Comment 1•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•